--enable-toolkit-cocoa to turn on building cocoa-specific things

RESOLVED FIXED in mozilla0.9.9

Status

RESOLVED FIXED
17 years ago
14 years ago

People

(Reporter: mikepinkerton, Assigned: mikepinkerton)

Tracking

Trunk
mozilla0.9.9
PowerPC
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

17 years ago
we need a way to turn on cocoa and set defines specific to it.

patch forthcoming.
(Assignee)

Comment 1

17 years ago
Created attachment 66172 [details] [diff] [review]
patch to configure.in

allows using --enable-toolkit-cocoa
(Assignee)

Comment 2

17 years ago
needing r/sr
Status: NEW → ASSIGNED
Summary: --enable-toolkit=cocoa to turn on building cocoa-specific things → --enable-toolkit-cocoa to turn on building cocoa-specific things
Target Milestone: --- → mozilla0.9.9
Comment on attachment 66172 [details] [diff] [review]
patch to configure.in

--enable-toolkit-<tk> is used to enable the building of support for multiple
toolkits in the same build.  What you want is to be able to use
--enable-default-toolkit=cocoa which means fixing the X11-only ness of that
option.
Attachment #66172 - Flags: needs-work+
Created attachment 66186 [details] [diff] [review]
Allow the default toolkit to be overridden on any platform
Attachment #66172 - Attachment is obsolete: true
(Assignee)

Comment 5

17 years ago
Comment on attachment 66186 [details] [diff] [review]
Allow the default toolkit to be overridden on any platform

looks good to me r=pink
Attachment #66186 - Flags: review+

Comment 6

17 years ago
Comment on attachment 66186 [details] [diff] [review]
Allow the default toolkit to be overridden on any platform

sr=hyatt
Attachment #66186 - Flags: superreview+
(Assignee)

Comment 7

17 years ago
Created attachment 66194 [details] [diff] [review]
makefile changes to accept a toolkit of cocoa (no configure changes)

this patch (which doesn't include cls' configure.in changes) updates the
makesfiles that relied on MOZ_WIDGET_TOOLKIT being mac. It globally changes
them to accept either mac or cocoa. We can tweak them as necessary later. This
also builds widget/src/cocoa if the flag is set to use cocoa.

needs r/sr as well.

Comment 8

17 years ago
Comment on attachment 66194 [details] [diff] [review]
makefile changes to accept a toolkit of cocoa (no configure changes)

sr=hyatt
Attachment #66194 - Flags: superreview+

Comment 9

17 years ago
QA to jj.
QA Contact: granrose → jj
Comment on attachment 66194 [details] [diff] [review]
makefile changes to accept a toolkit of cocoa (no configure changes)

r=cls
Attachment #66194 - Flags: review+
(Assignee)

Comment 11

17 years ago
everything landed on trunk. 
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.