Closed Bug 121496 Opened 23 years ago Closed 23 years ago

--enable-toolkit-cocoa to turn on building cocoa-specific things

Categories

(SeaMonkey :: Build Config, defect)

Product:
SeaMonkey
Component:
Build Config
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.9

People

(Reporter: mikepinkerton, Assigned: mikepinkerton)

Details

Attachments

(2 files, 1 obsolete file)

Allow the default toolkit to be overridden on any platform
5.45 KB, patch
mikepinkerton
: review+
hyatt
: superreview+
Details | Diff | Splinter Review
makefile changes to accept a toolkit of cocoa (no configure changes)
12.66 KB, patch
netscape
: review+
hyatt
: superreview+
Details | Diff | Splinter Review 
we need a way to turn on cocoa and set defines specific to it.

patch forthcoming.
Attached patch patch to configure.in (obsolete) — — Splinter Review 
allows using --enable-toolkit-cocoa
needing r/sr
Status: NEW → ASSIGNED
Summary: --enable-toolkit=cocoa to turn on building cocoa-specific things → --enable-toolkit-cocoa to turn on building cocoa-specific things
Target Milestone: --- → mozilla0.9.9
Comment on attachment 66172 [details] [diff] [review]
patch to configure.in

--enable-toolkit-<tk> is used to enable the building of support for multiple
toolkits in the same build.  What you want is to be able to use
--enable-default-toolkit=cocoa which means fixing the X11-only ness of that
option.
Attachment #66172 - Flags: needs-work+
Comment on attachment 66186 [details] [diff] [review]
Allow the default toolkit to be overridden on any platform

looks good to me r=pink
Attachment #66186 - Flags: review+
Comment on attachment 66186 [details] [diff] [review]
Allow the default toolkit to be overridden on any platform

sr=hyatt
Attachment #66186 - Flags: superreview+
this patch (which doesn't include cls' configure.in changes) updates the
makesfiles that relied on MOZ_WIDGET_TOOLKIT being mac. It globally changes
them to accept either mac or cocoa. We can tweak them as necessary later. This
also builds widget/src/cocoa if the flag is set to use cocoa.

needs r/sr as well.
Comment on attachment 66194 [details] [diff] [review]
makefile changes to accept a toolkit of cocoa (no configure changes)

sr=hyatt
Attachment #66194 - Flags: superreview+
QA to jj.
QA Contact: granrose → jj
Comment on attachment 66194 [details] [diff] [review]
makefile changes to accept a toolkit of cocoa (no configure changes)

r=cls
Attachment #66194 - Flags: review+
everything landed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: