1215004 - [Stingray][fling-player][TV][2.5] (TV side) Should update to the latest Presentation API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Fling, defect, P1)

Description

[Fischer [:Fischer]]

The Presentation API had been updated on 2015-10-12 (Bug 1212702):
1. Interface PresentationSession is renamed to PresentationConnection.
2. Enumeration PresentationSessionState is renamed to PresentationConnectionState.
3. PresentationRequest's event handler "onsessionconnect" is renamed to "onconnectionavailable" and fires a renamed event "PresentationConnectionAvailableEvent".
4. PresentationReceiver's method "getSession()" is renamed to "getConnection()".

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:ft-presentation-cast-video > mozilla-b2g:master

Comment 2

[Fischer [:Fischer]]

Attachment: PR #32554

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8675635 [details] [review]
PR #32554

The patch for updating presentation API is good. But for the unit test part, there are some improvement needed.
The presentation API mock is not easy to complete, thank you so much! I think there are some conventions we need to be aware. We can discuss it tomorrow.

Since the unit tests are not strongly related to this bug, let's check-in the update to presentation API first and leave the unit tests in another bug so that QA can start their works earlier.

Comment 4

[Fischer [:Fischer]]

Separate the unit test. Will open another bug for the unit test, thank you.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8675635 [details] [review]
PR #32554

Looks good to me!

Comment 6

[Fischer [:Fischer]]

Land to master: https://github.com/mozilla-b2g/gaia/commit/c2a42fc2d8b77086075b06f76c2074c0242dc814