[Stingray][fling-player][TV][2.5] (TV side) Should update to the latest Presentation API

RESOLVED FIXED

Status

Firefox OS
Gaia::TV::Fling
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Fischer, Assigned: Fischer)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices][partner-cherry-picked<2015/11/10>])

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
The Presentation API had been updated on 2015-10-12 (Bug 1212702):
1. Interface PresentationSession is renamed to PresentationConnection.
2. Enumeration PresentationSessionState is renamed to PresentationConnectionState.
3. PresentationRequest's event handler "onsessionconnect" is renamed to "onconnectionavailable" and fires a renamed event "PresentationConnectionAvailableEvent".
4. PresentationReceiver's method "getSession()" is renamed to "getConnection()".
(Assignee)

Updated

2 years ago
Assignee: nobody → fliu
Depends on: 1212702
(Assignee)

Updated

2 years ago
No longer blocks: 1210702
(Assignee)

Updated

2 years ago
Blocks: 1216058
(Assignee)

Updated

2 years ago
No longer blocks: 1216058

Comment 1

2 years ago
Created attachment 8675619 [details] [review]
[gaia] Fischer-L:ft-presentation-cast-video > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Created attachment 8675635 [details] [review]
PR #32554
Attachment #8675635 - Flags: review?(rexboy)
Comment on attachment 8675635 [details] [review]
PR #32554

The patch for updating presentation API is good. But for the unit test part, there are some improvement needed.
The presentation API mock is not easy to complete, thank you so much! I think there are some conventions we need to be aware. We can discuss it tomorrow.

Since the unit tests are not strongly related to this bug, let's check-in the update to presentation API first and leave the unit tests in another bug so that QA can start their works earlier.
Attachment #8675635 - Flags: review?(rexboy)
(Assignee)

Updated

2 years ago
Attachment #8675635 - Flags: review?(rexboy)
(Assignee)

Comment 4

2 years ago
Separate the unit test. Will open another bug for the unit test, thank you.
(Assignee)

Updated

2 years ago
Depends on: 1217287
(Assignee)

Updated

2 years ago
Depends on: 1217288
Comment on attachment 8675635 [details] [review]
PR #32554

Looks good to me!
Attachment #8675635 - Flags: review?(rexboy) → review+
(Assignee)

Comment 6

2 years ago
Land to master: https://github.com/mozilla-b2g/gaia/commit/c2a42fc2d8b77086075b06f76c2074c0242dc814
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Depends on: 1219542
(Assignee)

Updated

2 years ago
Depends on: 1220058
(Assignee)

Updated

2 years ago
Depends on: 1222364

Updated

2 years ago
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices][partner-cherry-picked<2015/11/10>]

Updated

2 years ago
Depends on: 1237532

Updated

2 years ago
No longer depends on: 1237532
(Assignee)

Updated

2 years ago
Depends on: 1240493
(Assignee)

Updated

2 years ago
No longer depends on: 1240493
You need to log in before you can comment on or make changes to this bug.