1215058 - Fix OOM handling behaviour related to off-thread compilation

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

Adding an oomTest test case that calls offThreadCompileScript() showed up a couple of issues.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1215058-off-thread-compile

Here's a patch to add the test case and fix the problems.  There turned out to be quite a few of these.

Mostly it's reporting OOM, distinguishing OOM failure from other errors and relaxing assertions when we've already had OOM.

One issue however is that js::ReportOutOfMemory() does nothing if it's called on a helper thread.  For reporting OOM when parsing off-main-thread, I assume that a null script result without any other error reported is due to OOM.  This seems to work but maybe another approach would be better.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8674857 [details] [diff] [review]
bug1215058-off-thread-compile

Review of attachment 8674857 [details] [diff] [review]:
-----------------------------------------------------------------

Nice fixes, thanks!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f1ff0ce8b6b

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6f1ff0ce8b6b