1215106 - DownloadContentService: Implement failure counters

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

The DownloadContentService tries to be smart and groups errors into recoverable and unrecoverable errors. Some of the errors are hard to classify: It could be a temporary error -> Recoverable: We want to retry -> However if this error is happening all the time then it might actually be an unrecoverable error.

Counting failures is an easy way out. If the number of failures for a given content passes a to be defined threshold then stop trying. As soon as the content changes in the catalog (bug 1200291) we can try again.

For this to work we will also need to implement a back-off strategy. We do not want to use all our retries in a short period of time.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1215106 - DownloadContentService: Mark content as permanently failed after multiple errors of the same type. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/28771/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28771/

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8700582 [details]
MozReview Request: Bug 1215106 - DownloadContentService: Mark content as permanently failed after multiple errors of the same type. r?rnewman

https://reviewboard.mozilla.org/r/28771/#review25759

::: mobile/android/base/java/org/mozilla/gecko/dlc/catalog/DownloadContentCatalog.java:127
(Diff revision 1)
> +        if (content.getFailures() == MAX_FAILURES_UNTIL_PERMANENTLY_FAILED) {

Paranoia: >=.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e93c4dab593

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Richard Newman [:rnewman] from comment #2)
> :::
> mobile/android/base/java/org/mozilla/gecko/dlc/catalog/
> DownloadContentCatalog.java:127
> (Diff revision 1)
> > +        if (content.getFailures() == MAX_FAILURES_UNTIL_PERMANENTLY_FAILED) {
> 
> Paranoia: >=.

Heh. I usually share this paranoia but here I've been trusting the tests. Nevertheless I'll change it to >=. :)

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/cf91309b02e19b37899d3e305fa5a51eafe6708f
Bug 1215106 - DownloadContentService: Mark content as permanently failed after multiple errors of the same type. r=rnewman

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cf91309b02e1