1215151 - Add XPCOM leak checking for base::Thread

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

This seems like another important structure we should track.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Add XPCOM leak checking for base::Thread.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5ec04884130

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8674934 [details] [diff] [review]
Add XPCOM leak checking for base::Thread.

Review of attachment 8674934 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/chromium/src/base/thread.cc
@@ +53,1 @@
>    Stop();

This can block until the thread exits.  I assume there's nothing about the MOZ_COUNT_DTOR being before it instead of after that's subtle enough to be commentworthy?

Comment 3

[Andrew McCreight [:mccr8]]

No particular reason. I just didn't know what the Stop() did so I figured it would be better to call COUNT_DTOR before it.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/944fe260a35c

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/944fe260a35c