Closed Bug 1215163 Opened 9 years ago Closed 9 years ago

Add setComposingRange and sendKeyEvent tests to testInputConnection

Categories

(Firefox for Android Graveyard :: Keyboards and IME, defect)

All
Android
defect
Not set
normal

Tracking

(firefox44 affected, firefox45 fixed, b2g-v2.5 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox44 --- affected
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

      No description provided.
Add tests for setComposingRange and sendKeyEvent to testInputConnection.
Attachment #8674433 - Flags: review?(esawin)
Comment on attachment 8674433 [details] [diff] [review]
Add additional tests to testInputConnection (v1)

Review of attachment 8674433 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Maybe we should add more edge cases, like setting the composing area on the complete text.
Attachment #8674433 - Flags: review?(esawin) → review+
I discovered that the key event tests led to some intermittent failures that are best addressed by bug 1216666, so I'll hold off landing this for now.
Depends on: 1216666
https://hg.mozilla.org/mozilla-central/rev/7d67a7bc8829
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: