Closed
Bug 1215163
Opened 9 years ago
Closed 9 years ago
Add setComposingRange and sendKeyEvent tests to testInputConnection
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect)
Tracking
(firefox44 affected, firefox45 fixed, b2g-v2.5 fixed)
RESOLVED
FIXED
Firefox 45
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(1 file)
4.01 KB,
patch
|
esawin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Add tests for setComposingRange and sendKeyEvent to testInputConnection.
Attachment #8674433 -
Flags: review?(esawin)
Comment 2•9 years ago
|
||
Comment on attachment 8674433 [details] [diff] [review] Add additional tests to testInputConnection (v1) Review of attachment 8674433 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Maybe we should add more edge cases, like setting the composing area on the complete text.
Attachment #8674433 -
Flags: review?(esawin) → review+
Assignee | ||
Comment 3•9 years ago
|
||
I discovered that the key event tests led to some intermittent failures that are best addressed by bug 1216666, so I'll hold off landing this for now.
Depends on: 1216666
Assignee | ||
Comment 4•9 years ago
|
||
bugherder landing |
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d67a7bc8829
Comment 5•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7d67a7bc8829
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Comment 6•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/7d67a7bc8829
status-b2g-v2.5:
--- → fixed
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•