1215167 - unsafe CPOW usage from non-addon code should throw

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

One thing I'm not sure of here is why the test_cpows.xul code isn't considered part of an add-on. Test code usually is. Maybe I'll look at that part a bit closer.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8678395 [details] [diff] [review]
patch

Review of attachment 8678395 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/test/chrome/cpows_parent.xul
@@ +399,5 @@
> +        msg.objects.f();
> +      } catch (e if /unsafe CPOW usage forbidden/.test(String(e))) {
> +        failed = true;
> +      }
> +      opener.wrappedJSObject.SpecialPowers.setBoolPref(PREF_UNSAFE_FORBIDDEN, false);

Maybe clearUserPref?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/89446bf8d6b8

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This apparently introduced a new hazard to the build: https://treeherder.mozilla.org/logviewer.html#?job_id=16811735&repo=mozilla-inbound

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7c43617a7215

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2215dc556dbc

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2215dc556dbc