Closed
Bug 1215169
Opened 9 years ago
Closed 9 years ago
Implement key navigation on FxA flow
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S10 (30Oct)
People
(Reporter: ferjm, Assigned: yifan)
References
Details
(Whiteboard: [partner-cherry-pick])
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•9 years ago
|
Blocks: TV_FxAccount
|
Reporter | |
Updated•9 years ago
|
Priority: -- → P1
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → yliao
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8677544 -
Flags: review?(ferjmoreno)
|
|
Reporter | |
Comment 2•9 years ago
|
||
I'll review this on the plane, but I see that there are some fxa tests failing. Could you fix them in the mean time, please? Thanks!
Flags: needinfo?(ferjmoreno)
|
|
Reporter | |
Comment 3•9 years ago
|
||
And now, needinfo the right person :)
Flags: needinfo?(ferjmoreno) → needinfo?(yliao)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Sorry for that. Test fixed and test cases updated. Oh... this update probably didn't catch the plane...
Flags: needinfo?(yliao) → needinfo?(ferjmoreno)
|
|
Reporter | |
Comment 5•9 years ago
|
||
Thank you YiFan! The linter is still complaining a little bit. https://treeherder.mozilla.org/logviewer.html#?job_id=2680321&repo=gaia
Flags: needinfo?(ferjmoreno)
|
|
Reporter | |
Comment 6•9 years ago
|
||
Comment on attachment 8677544 [details] [review] [gaia] begeeben:1215169_implement_key_navigation_on > mozilla-b2g:master Great work YiFan! r=me with the comments addressed, please.
Attachment #8677544 -
Flags: review?(ferjmoreno) → review+
|
|
Assignee | |
Comment 7•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/1a7646c021a4dcd9441fa82f304e80a501a22aae
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
You need to log in
before you can comment on or make changes to this bug.
Description
•