Closed Bug 1215169 Opened 4 years ago Closed 4 years ago

Implement key navigation on FxA flow

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S10 (30Oct)

People

(Reporter: ferjm, Assigned: yifan)

References

Details

(Whiteboard: [partner-cherry-pick])

Attachments

(1 file)

No description provided.
Blocks: fxos-sync
Target Milestone: --- → FxOS-S10 (30Oct)
Blocks: TV_FxAccount
Priority: -- → P1
Assignee: nobody → yliao
Depends on: 1203898
Attachment #8677544 - Flags: review?(ferjmoreno)
I'll review this on the plane, but I see that there are some fxa tests failing. Could you fix them in the mean time, please? Thanks!
Flags: needinfo?(ferjmoreno)
And now, needinfo the right person :)
Flags: needinfo?(ferjmoreno) → needinfo?(yliao)
Sorry for that. Test fixed and test cases updated. Oh... this update probably didn't catch the plane...
Flags: needinfo?(yliao) → needinfo?(ferjmoreno)
Thank you YiFan! The linter is still complaining a little bit.

https://treeherder.mozilla.org/logviewer.html#?job_id=2680321&repo=gaia
Flags: needinfo?(ferjmoreno)
Comment on attachment 8677544 [details] [review]
[gaia] begeeben:1215169_implement_key_navigation_on > mozilla-b2g:master

Great work YiFan! r=me with the comments addressed, please.
Attachment #8677544 - Flags: review?(ferjmoreno) → review+
Blocks: 1218314
https://github.com/mozilla-b2g/gaia/commit/1a7646c021a4dcd9441fa82f304e80a501a22aae
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Blocks: 1220573
No longer blocks: 1220573
Blocks: 1220961
No longer blocks: 1220961
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.