1215196 - A bunch of serviceworker test resource files act like separate tests

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Boris Zbarsky [:bzbarsky]]

There are six HTML files in testing/web-platform/mozilla/tests/service-workers/service-worker/resources that include testharness.js.  That makes them testharness tests for purposes of the harness, so it tries to run them.  And they're not tests, so they time out.

Now 5 of these have .ini files saying they time out.  The 6th one was added in bug 1210581 and isn't added to the manifest yet, but the next time there's a test import it will be, I bet, and pick up its own .ini file.

Worse yet, it's a land mine for anyone using mach web-platform-tests-create, since that will add it to the manifest.

The relevant files:

resources/fetch-request-resources-iframe.https.html
resources/fetch-request-xhr-iframe.https.html
resources/fetch-response-xhr-iframe.https.html
resources/invalid-blobtype-iframe.https.html
resources/invalid-header-iframe.https.html
resources/worker-interception-iframe.https.html

Comment 1

[(no longer active)]

Hmm, which manifest are you talking about?  I thought that these tests are run by some kind of directory traversal, not by declaring them in manifests?

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

This manifest:

  https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/mozilla/meta/MANIFEST.json

And for example, these are not tests:

  https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/mozilla/meta/service-workers/service-worker/resources

The wpt tests assume anything importing testharness.js are a test.

Comment 3

[Boris Zbarsky [:bzbarsky]]

> I thought that these tests are run by some kind of directory traversal, not by declaring 
> them in manifests?

There is a script that does a directory traversal and builds a manifest.  It's normally run when we take a new test import from upstream or when new tests are added.  The tests are run based on the manifest.

Comment 4

[(no longer active)]

Attachment: Fix web-platform-tests iframe scripts to avoid pulling in testharness.js in them

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01dd15e9d658

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/01dd15e9d658