Closed Bug 1215196 Opened 4 years ago Closed 4 years ago
A bunch of serviceworker test resource files act like separate tests
There are six HTML files in testing/web-platform/mozilla/tests/service-workers/service-worker/resources that include testharness.js. That makes them testharness tests for purposes of the harness, so it tries to run them. And they're not tests, so they time out. Now 5 of these have .ini files saying they time out. The 6th one was added in bug 1210581 and isn't added to the manifest yet, but the next time there's a test import it will be, I bet, and pick up its own .ini file. Worse yet, it's a land mine for anyone using mach web-platform-tests-create, since that will add it to the manifest. The relevant files: resources/fetch-request-resources-iframe.https.html resources/fetch-request-xhr-iframe.https.html resources/fetch-response-xhr-iframe.https.html resources/invalid-blobtype-iframe.https.html resources/invalid-header-iframe.https.html resources/worker-interception-iframe.https.html
Hmm, which manifest are you talking about? I thought that these tests are run by some kind of directory traversal, not by declaring them in manifests?
This manifest: https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/mozilla/meta/MANIFEST.json And for example, these are not tests: https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/mozilla/meta/service-workers/service-worker/resources The wpt tests assume anything importing testharness.js are a test.
> I thought that these tests are run by some kind of directory traversal, not by declaring > them in manifests? There is a script that does a directory traversal and builds a manifest. It's normally run when we take a new test import from upstream or when new tests are added. The tests are run based on the manifest.
Attachment #8675073 - Flags: review?(bkelly) → review+
You need to log in before you can comment on or make changes to this bug.