1215239 - When going from one web site komonews.com to google.com the web page appears black.

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[[:VladimirBelonenko]]

Attachment: logcat_20151015_1115.txt

Description:
When user goes to komonews web site and switches to google.com web page, the screen is black.

Repro Steps:
1) Update a Aries to 20151015110122
2) Open Browser
3) Go to komonews.com click on Photo link: Celebs turn out for Cosmo magazine Picture.(link address: http://www.komonews.com/news/entertainment/Photos-Celebs-turn-out-for-Cosmo-332809181.html)
4) Go to google.com
5) Observe that google screen is black not white.

Actual:
When user selects specific komonews article and goes to google.com web page, google web page color is black.

Expected:
User should not have any problems when going from web page to web page.

Notes: User has to go from komotv.com page specific article to google.com

Environmental Variables:
Device: Aries Master 2.5 kk full flash 
Build ID: 20151015110122
Gaia: 40ae7c292a36156458c66712b4bd61ecbe69272a
Gecko: e193b4da0a8c1025aa76a403c64663ff1cd41709
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (Master)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 2/3
See attached: video clip and log cat

Comment 1

[[:VladimirBelonenko]]

This issue occurs on 2.5 flame 
Result: When user selects specific komonews.com article and goes to google.com web page, google web page color is black.

Environmental Variables:
Device: Flame Master 2.5 kk full flash
Build ID: 20151015030226
Gaia: 40ae7c292a36156458c66712b4bd61ecbe69272a
Gecko: e193b4da0a8c1025aa76a403c64663ff1cd41709
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (Master)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

This issue does not occurs on 2.2 flame
Result: User did not had any problems when going from web page to web page.

Environmental Variables:
Device: Flame 2.2 kk full flash
BuildID: 20151006032504
Gaia: 5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583
Gecko: fc588eb28eab
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame 2.5
BuildID: 20151013175331
Gaia: 879b8d17e2082779b99917e507097d4aef34b79c
Gecko: ac9f96ca40cb0d4cfe4e79bbc126ba9309a87516
Version: 44.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

First Broken
Device: Flame 2.5
BuildID: 20151013195318
Gaia: 879b8d17e2082779b99917e507097d4aef34b79c
Gecko: cde243d573472684a21b3a38d2b2dff620a50307
Version: 44.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Gaia is the same so it's a Gecko issue.

Gecko pushlog:
http://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=ac9f96ca40cb0d4cfe4e79bbc126ba9309a87516&tochange=cde243d573472684a21b3a38d2b2dff620a50307

Caused by changes made in Bug 1191740.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Kan-Ru and Steven, you both made changes for bug 1191740 which seems to be the cause here.  Can you please take a look at the pushlog?

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

Looking

Comment 5

[Kan-Ru Chen [:kanru] (UTC+9)]

Google home page uses default background-color which happens to be "transparent", I'm not sure if this is correct. If the previous page has background-color set to another color, it somehow gets reused which is strange too. I don't understand how the changes in bug 1191740 could affect this yet.

Comment 6

[Kan-Ru Chen [:kanru] (UTC+9)]

Reduced test case: visit following pages

http://people.mozilla.org/~kchen/bug1215239/test.html
http://people.mozilla.org/~kchen/bug1215239/test2.html

The second page will have the color of the first page.

Comment 7

[Kan-Ru Chen [:kanru] (UTC+9)]

Looks like it's a very old bug exposed by something else. The window manager captures background-color but only if it's in rgb() format. The default value "transparent" will not pass so the previous color remains set.

https://github.com/mozilla-b2g/gaia/blob/043b7c9231335e2257588005ab9c13dcdb7fc3c4/apps/system/js/app_window.js#L1111

Comment 8

[Kan-Ru Chen [:kanru] (UTC+9)]

And reverting my commits do fix the symptom. Maybe it's related to isBrowserElement or isApp check.

Comment 9

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Don't set ownApp for a browser element

Because we set mAppId to the containing appId we have to check mInBrowser explicitly.

Comment 10

[Bobby Holley (:bholley)]

Comment on attachment 8675633 [details] [diff] [review]
Don't set ownApp for a browser element

Review of attachment 8675633 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/TabContext.cpp
@@ +285,5 @@
>      }
>    }
>  
> +  nsCOMPtr<mozIApplication> ownApp;
> +  if (!originAttributes.mInBrowser) {

Add a comment here saying that mAppId corresponds to OwnOrContainingAppId, which is why we need to check mInBrowser.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/f282f8148b14

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f282f8148b14