1215290 - Cache API should store the unfiltered response URL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently Cache API just stores the content visible response URL.  It should be storing the real unfiltered URL to fully recreate the Response on cache.match().  Currently opaque responses read from Cache API will have an empty string unfiltered URL.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Cache API should store unfiltered Response URL. r=ehsan

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4417f0eeeee

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e4417f0eeeee

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8674492 [details] [diff] [review]
Cache API should store unfiltered Response URL. r=ehsan

Approval Request Comment
[Feature/regressing bug #]: service workers and cache API
[User impact if declined]: We need this to fully support certain types of service worker interception.  In particular, I want to uplift this to avoid the corner case where someone creates a Cache in 43, gets a wrong URL stored on disk, and then later runs into a problem when we enable service worker opaque interception.
[Describe test coverage new/current, TreeHerder]: No impact until service workers enabled.
[Risks and why]: None.  One line change and no user visible effect yet.
[String/UUID change made/needed]:  None.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Again, I want to get this in 43 so that people don't create cache objects on disk that will later be a problem when we enable service workers.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8674492 [details] [diff] [review]
Cache API should store unfiltered Response URL. r=ehsan

OK to uplift to aurora; SW will be disabled by default soon but it will be good to make sure this is consistent in 43

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8c1c01f9f089