Closed Bug 1215336 Opened 4 years ago Closed 4 years ago

Measure unmark gray time

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In trying to grok the existing code, I got curious about how much time we spend in unmark gray. It would be nice to track this, and get telemetry if it gets out of hand.
Attachment #8674577 - Flags: review?(terrence)
Attachment #8674577 - Flags: review?(terrence) → review+
(In reply to Phil Ringnalda (:philor) from comment #3)
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/1266f78145c4 in hopes
> that we'll stop seeing
> 
> https://treeherder.mozilla.org/logviewer.html#?job_id=15789159&repo=mozilla-
> inbound
> https://treeherder.mozilla.org/logviewer.html#?job_id=15790938&repo=mozilla-
> inbound
> https://treeherder.mozilla.org/logviewer.html#?job_id=15791014&repo=mozilla-
> inbound
> https://treeherder.mozilla.org/logviewer.html#?job_id=15793433&repo=mozilla-
> inbound
> 
> etc.

Ugh. Yes, that looks like this bug's fault. I was worried about it when I made the patch, but it looked ok when stepping through it, and although my try push was half orange/red (as is the norm these days), it did not report this problem. The stacks in those links will be very helpful, though. Thanks.
Well, I don't know what https://treeherder.mozilla.org/logviewer.html#?job_id=15790938&repo=mozilla-inbound was. That is unlikely to be from this patch.
https://hg.mozilla.org/mozilla-central/rev/380cc4f59840
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.