1215371 - the cancel button of email reply action list is not clear

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[[e-mail]]

User-Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Step:
1. open a mail in mail app
2. Press the reply button at bottom right
3. The reply action list is shown with 3 options

the bottom cancel button is unclear, the font color will change to white when user tap it

seems all action menu share the same issue.

Comment 1

[[e-mail]]

Attachment: 2015-10-16-09-07-17.png

Comment 2

[[e-mail]]

@harly does it the expected font color for default Cancel button?

Comment 3

[Harly Hsu[:harly]]

Attachment: 2015-10-16-11-54-33.png

I am seeing this in all the menu within the system, so I think this is a bug related to system component.

Comment 4

[[e-mail]]

looks like a regression.

Comment 5

[Gregor Wagner [:gwagner]]

Kevin, is this on your radar?

Comment 6

[Kevin Grandon :kgrandon]

I could take a look when time permits.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1215371_email_menu_buttons > mozilla-b2g:master

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8675326 [details] [review]
[gaia] KevinGrandon:bug_1215371_email_menu_buttons > mozilla-b2g:master

Andrew or James - Could either one of you give this a review as time permits? Thanks!

Comment 9

[James Burke [:jrburke]]

Comment on attachment 8675326 [details] [review]
[gaia] KevinGrandon:bug_1215371_email_menu_buttons > mozilla-b2g:master

I will review. Did a quick pass, and I think there may be more to modify, like the save draft confirmation, but I will need to scrub it more. The reply_menu.html one looks like the Cancel text appears off-center. I will do more investigation though later, may not be until Monday though.

Comment 10

[Kevin Grandon :kgrandon]

Thanks for the quick pass. I've pushed two changes which address the off-center reply cancel, and the safe draft cancel button. They're individual commits right now for ease of review, but will squash them before landing.

Comment 11

[James Burke [:jrburke]]

Comment on attachment 8675326 [details] [review]
[gaia] KevinGrandon:bug_1215371_email_menu_buttons > mozilla-b2g:master

Looks great, thank you!

Comment 12

[Kevin Grandon :kgrandon]

Thanks for the review. Try is green, so landing in master: https://github.com/mozilla-b2g/gaia/commit/3491a49da4d4ce45b8a682e95d0ce68892c2b8ea

Comment 13

[zouyi(Leave from Mozilla)]

Attachment: Verified_Aries_KK_v2.6.png

This bug has been verified as "pass" on the latest build of Aries KK v2.6 and Flame KK 2.5&2.6 512mb by the STR in comment 0.

Actual results: Press the reply button of an email, cancel button at the bottom is clear, and the font color will not change to white when user taps it.
See attachment: Verified_Aries_KK_v2.6.png

Reproduce rate: 0/10

Device: Aries KK 2.6 (master) (Pass)
Build ID               20151104004249
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151104.000116
Firmware Date          Wed Nov  4 00:01:24 UTC 2015
Bootloader             s1


Device: Flame KK 2.6 512mb (master)(Pass)                                                                       
Build ID               20151103150203
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151103.182550
Firmware Date          Tue Nov  3 18:26:03 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5 512mb (Pass)
Build ID               20151103004501
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4e0955369a51850f2982087145ac5c2df257ffe9
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151103.054921
Firmware Date          Tue Nov  3 05:49:36 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 14

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest Aries KK 2.5 by the STR in comment 0.

Actual results: The bottom Cancel button is clear and shows normally when tapping on it in email app.
See attachment: verified_Aries_v2.5.png
Reproduce rate: 0/10


Device: Aries KK 2.5 (Pass)
Build ID               20151107112205
Gaia Revision          577948202ae12154524a2bd2bd6d467838ad50b8
Gaia Date              2015-11-07 10:00:59
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae7b8b1fd9e1504347b938820f99d75058049386
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151107.104119
Firmware Date          Sat Nov  7 10:41:27 UTC 2015
Bootloader             s1

Comment 15

[Shally Li（leave from Mozilla）]

Attachment: verified_Aries_v2.5.png