Remove per-test appdir configurability

NEW
Unassigned

Status

defect
4 years ago
Last year

People

(Reporter: jryans, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

If you have xpcshell tests that need files from /browser, you currently have to add:

firefox-appdir = browser

to the test manifest.

This is unnecessary busy work, and it also prevents those tests from running on other apps where this is the incorrect appdir.

It's also the only appdir setting ever used in the tree.  Let's special case Firefox builds instead, and remove the option.
I think I've been able to work around this for now.  It doesn't actually block tests on other apps, since the appdir isn't consulted for them.  Still, it's annoying to set for Firefox.
No longer blocks: 1203159
This was added to support testing Metro/webruntime stuff, but having it default to "browser" would probably be fine. Those tests will presumably fail if Thunderbird or Seamonkey tried to run them.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> This was added to support testing Metro/webruntime stuff, but having it
> default to "browser" would probably be fine. Those tests will presumably
> fail if Thunderbird or Seamonkey tried to run them.

That's what I tried first, but unfortunately there are quite a few tests that require the current default of **not** passing the Firefox app dir...  So, either all those tests need to change or they need to opt out of the app dir...

Doesn't seem like there is an easy fix here.
Assignee: jryans → nobody
Status: ASSIGNED → NEW
See Also: → 1465467
Duplicate of this bug: 1465467
You need to log in before you can comment on or make changes to this bug.