WebGL 2 - InvalidateFB doesn't check params correctly.

NEW
Unassigned

Status

()

P3
normal
3 years ago
11 months ago

People

(Reporter: kamidphish, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gfx-noted], URL)

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8674715 [details] [diff] [review]
validate params to invalidate{Sub}Framebuffer.
Attachment #8674715 - Flags: review?(jgilbert)
Comment on attachment 8674715 [details] [diff] [review]
validate params to invalidate{Sub}Framebuffer.

Review of attachment 8674715 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContextValidate.cpp
@@ +378,5 @@
>   * be one of depth/stencil/depth_stencil/color attachment.
>   */
>  bool
>  WebGLContext::ValidateFramebufferAttachment(const WebGLFramebuffer* fb, GLenum attachment,
> +                                            const char* funcName, bool invalidateFB)

`isInvalidateFunc` I think is clearer.
Attachment #8674715 - Flags: review?(jgilbert) → review+
Assignee: dglastonbury → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.