1215416 - WebGL 2 - InvalidateFB doesn't check params correctly.

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P3)

Comment 1

[u480271]

Attachment: validate params to invalidate{Sub}Framebuffer.

Comment 2

[u480271]

try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3b849b5994d

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8674715 [details] [diff] [review]
validate params to invalidate{Sub}Framebuffer.

Review of attachment 8674715 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContextValidate.cpp
@@ +378,5 @@
>   * be one of depth/stencil/depth_stencil/color attachment.
>   */
>  bool
>  WebGLContext::ValidateFramebufferAttachment(const WebGLFramebuffer* fb, GLenum attachment,
> +                                            const char* funcName, bool invalidateFB)

`isInvalidateFunc` I think is clearer.