1215462 - [PulseGuardian] Pulse warning emails should contain link to PulseGuardian website

Status: RESOLVED FIXED

(Webtools :: Pulse, enhancement, P5)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yesterday I got an email that two of my queues are overgrowing. I wanted to have a look at it but sadly I forgot the website URL due to the latest move. So it would be great if a link would be contained which directly brings you to the queues page at https://pulseguardian.mozilla.org/

Comment 1

[kofishmalofi]

Hello,

I am a new coding student of OSS and would like to try my hand at this.

Thank you

KF

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Hi KF!

You can find the source for this application at https://github.com/mozilla-services/pulseguardian. I actually don't know the code very well, so we can explore this together. See if you can figure out where in the code it creates emails with subjects like "Pulse warning: queue <queuename> is overgrowing". That's where the link that Henrik suggests would be added. Once you've found that, add the link and make a pull request!

Comment 3

[kofishmalofi]

I think I found it, but just want to be sure. It appears to be in the "guardian.py" file. The function is "warning_email" line 274. Is it the correct one?

Also, what is the link that should be added? Sorry about all the questions.

Thanks

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

That looks right! The link is https://pulseguardian.mozilla.org/queues

Comment 5

[kofishmalofi]

Thanks.

So, when I create a pull request,should I refer to it as Bug #1215462 ?

txs

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Yes :)

We have some best-practices for commit messages here that also apply to PulseGuardian.

Comment 7

[kofishmalofi]

PR created :-) https://github.com/mozilla-services/pulseguardian/pull/169

Comment 8

[kofishmalofi]

Thanks for guiding me through that PR.

And the answer to your question there, yes, please. I'm hooked. :)

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

How about https://bugzilla.mozilla.org/show_bug.cgi?id=1403343?