Closed Bug 1215474 Opened 10 years ago Closed 3 years ago

Top bar is lagging while scrolling

Categories

(Web Compatibility :: Site Reports, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: 2ljpswpih, Unassigned)

References

()

Details

(Keywords: webcompat:contact-ready, Whiteboard: [country-pl] [css] )

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0 Build ID: 20151014030223 Steps to reproduce: Go to http://www.erasmus.uz.zgora.pl/rekrutacja/ in Nightly. Scroll down and up. Actual results: Top bar is lagging while scrolling Expected results: Top bar should behave properly (for example, like in Chrome).
Reproducible with APZ enabled. Doesn't reproduce if I disable it.
Status: UNCONFIRMED → NEW
Component: Untriaged → Panning and Zooming
Ever confirmed: true
Product: Firefox → Core
They are using a scroll listener to move the bar. This is necessarily going to be laggy with APZ enabled; they should switch to using position:sticky to get the desired effect with async scrolling. Moving to TE to reach out to them.
Component: Panning and Zooming → Desktop
Product: Core → Tech Evangelism
Version: 44 Branch → Trunk
There is a contact form here: http://www.erasmus.uz.zgora.pl/kontakt/ Would be nice if a Polish person could contact them. We don't have any volunteer from Poland on the web compatibility team at the moment, maybe the reporter could reach out to the site? TIA! :)
Flags: needinfo?(to_du)
Do I understand it wright? The site administrator doesn't build site properly and they should change something? When it comes to contact, I don't think that there will be any problem with contacting them in English. And I don't know what does "TIA" means. ;)
Flags: needinfo?(to_du)
(In reply to to_du from comment #4) > Do I understand it wright? The site administrator doesn't build site > properly and they should change something? Yes, we suggest this change: instead of moving the top navigation element on every scroll event, set element.style.position='sticky' (and if required element.style.top='0px' or similar to get the effect they want) instead. This way the web browser will keep the element at the top of the screen during scrolling automatically. Scrolling will be a smoother and nicer experience after this change. There's further documentation of position:sticky here: https://developer.mozilla.org/en-US/docs/Web/CSS/position (The scroll event based code is still required as a backup since some browsers don't support position:sticky yet) > When it comes to contact, I don't think that there will be any problem with > contacting them in English. > And I don't know what does "TIA" means. ;) TIA means "Thanks in advance" :) Can you send them a message, in either English or Polish?
(To be absolutely clear: what they are doing is not "wrong", it's just less efficient - meaning it will cause more lagging and strange effects during scrolling, especially on phones with less powerful hardware. We'd like to make them aware of a better way to code the effect they want, but it's of course up to them if they will take our advice or not.)
It will be better if someone from your company can do it. I'm not specialist at this and it would be a little bit strange to me to suggest them better way of building page.
(In reply to to_du from comment #7) > It will be better if someone from your company can do it. I'm not specialist > at this and it would be a little bit strange to me to suggest them better > way of building page. to_du: You can help by contacting them. And in your message include the link to this bug report, and tell them for any technical discussions, they can ask here. Thanks a lot already for everything you did.
Flags: needinfo?(to_du)
Whiteboard: [country-pl] [css]
Ok, I have contacted them.
Flags: needinfo?(to_du)
The situation has not changed. <nav style="clear: both; position: absolute; left: 0px; top: 32px;" id="mainnav"> <ul id="menu-menu-glowne" class="mainmenu"> <!-- cut menu items --> </ul> </nav> Replacing position: absolute by position sticky will not help here. It will not have the intended effect. They currently have. Maybe before contacting, we should really come up with something which is working and which piece of code we need to change. I'm putting back to needsdiagnosis.
Whiteboard: [country-pl] [css] → [country-pl] [css] [needsdiagnosis]
Contact form is http://www.erasmus.uz.zgora.pl/kontakt/ Maybe contacting Tomasz Hebisz T.Hebisz@gmail.com could help
Priority: -- → P3
Priority: P3 → P5
Product: Tech Evangelism → Web Compatibility

See bug 1547409. Moving webcompat whiteboard tags to keywords.

They also needs to remove this

	var topOffset = jQuery('#mainnavcontainer').offset().top-jQuery('.topheader').offset().top; //get the offset top of the element
  	jQuery(window).scroll(function() { //when window is scrolled
	  	iOff = topOffset  - jQuery(window).scrollTop();
	  	if(iOff<0) jQuery('#mainnav').css('top',-iOff);
	  	else jQuery('#mainnav').css('top',0);
  	});

moving to contact ready

Whiteboard: [country-pl] [css] [needsdiagnosis] → [country-pl] [css]

I can't reproduce this on my side. Top bar is not lagging while scrolling the page up/down.

Tested with:
Browser / Version: Firefox Nightly 101.0a1 (2022-04-05)
Operating System: Windows 10 Pro

2ljpswpih can you still reproduce it on your side?

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.