Closed Bug 1215508 Opened 5 years ago Closed 5 years ago

Crash in TabChild::PreloadSlowThings() due to race

Categories

(Firefox OS Graveyard :: Stability, defect)

x86
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
FxOS-S10 (30Oct)
Tracking Status
firefox44 --- fixed

People

(Reporter: cyu, Assigned: cyu)

Details

Attachments

(1 file)

This is found when running mochitest on emulator-x86-kk only. On ARM emulator, I can run the tests repeatedly over the weekend without the crash.

In TabChild::PreloadSlowThings(), class MessageChannelAutoBlock() accesses the IPC channels of opened actors in a racy way: in MessageChannelAutoBlock::SetMessageChannelBlocked(), the IPC channel might not yet be opened (on another thread). The Nuwa process then crashes in dereferencing a nullptr.
https://hg.mozilla.org/integration/b2g-inbound/rev/d867176a590ac65a54da92a5706f97e938fbea39
Bug 1215508: Fix the race in accessing the unopened IPC channels in TabChild::PreloadSlowThings(). r=khuey
https://hg.mozilla.org/mozilla-central/rev/d867176a590a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S10 (30Oct)
You need to log in before you can comment on or make changes to this bug.