Closed
Bug 1215508
Opened 6 years ago
Closed 6 years ago
Crash in TabChild::PreloadSlowThings() due to race
Categories
(Firefox OS Graveyard :: Stability, defect)
Tracking
(firefox44 fixed)
RESOLVED
FIXED
FxOS-S10 (30Oct)
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: cyu, Assigned: cyu)
Details
Attachments
(1 file)
|
1.82 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
This is found when running mochitest on emulator-x86-kk only. On ARM emulator, I can run the tests repeatedly over the weekend without the crash. In TabChild::PreloadSlowThings(), class MessageChannelAutoBlock() accesses the IPC channels of opened actors in a racy way: in MessageChannelAutoBlock::SetMessageChannelBlocked(), the IPC channel might not yet be opened (on another thread). The Nuwa process then crashes in dereferencing a nullptr.
|
Assignee | |
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d931f4a2cfc
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #8674862 -
Flags: review?(khuey)
Attachment #8674862 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/d867176a590ac65a54da92a5706f97e938fbea39 Bug 1215508: Fix the race in accessing the unopened IPC channels in TabChild::PreloadSlowThings(). r=khuey
|
||
Comment 4•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d867176a590a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S10 (30Oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•