Crash in TabChild::PreloadSlowThings() due to race

RESOLVED FIXED in Firefox 44

Status

Product:
Firefox OS Graveyard
Component:
Stability
Type:
defect
Status:
RESOLVED FIXED
Opened:
4 years ago
Updated:
4 years ago

People

(Reporter: cyu, Assigned: cyu)

Tracking

Version:
unspecified
Target:
FxOS-S10 (30Oct)
Platform:
x86
Gonk (Firefox OS)

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

Don't block/unblock IPC channels running off main thread
1.82 KB, patch
khuey
: review+
Details | Diff | Splinter Review 
This is found when running mochitest on emulator-x86-kk only. On ARM emulator, I can run the tests repeatedly over the weekend without the crash.

In TabChild::PreloadSlowThings(), class MessageChannelAutoBlock() accesses the IPC channels of opened actors in a racy way: in MessageChannelAutoBlock::SetMessageChannelBlocked(), the IPC channel might not yet be opened (on another thread). The Nuwa process then crashes in dereferencing a nullptr.
https://hg.mozilla.org/integration/b2g-inbound/rev/d867176a590ac65a54da92a5706f97e938fbea39
Bug 1215508: Fix the race in accessing the unopened IPC channels in TabChild::PreloadSlowThings(). r=khuey
https://hg.mozilla.org/mozilla-central/rev/d867176a590a
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S10 (30Oct)
You need to log in before you can comment on or make changes to this bug.