Closed
Bug 1215559
Opened 9 years ago
Closed 9 years ago
Make WebIDL iterable interfaces not require GetKeyAtIndex method if they only use a value
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: qdot, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
17.61 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
Currently, WebIDL interfaces with iterable<> members are required to implement both GetKeyAtIndex() and GetValueAtIndex(), even if they only iterate over an interface that exposes a value alone i.e. (iterable<long>). We shouldn't require developers to implement both methods when we can just have GetKeyAtIndex() call GetValueAtIndex() for those cases.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8675038 -
Flags: review?(kyle)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8675038 [details] [diff] [review] Like so, say? Review of attachment 8675038 [details] [diff] [review]: ----------------------------------------------------------------- Yup, just like that.
Attachment #8675038 -
Flags: review?(kyle) → review+
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/251fef43b7eb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•