Remove redundant icon property from MenuItemInfo

RESOLVED FIXED in Firefox 44

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: vivek, Assigned: vivek, Mentored)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

(Whiteboard: [lang=java])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
As mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1162107#c6, icon property was deprecated from menu add-on API. This bug removes that deprecated property from code
(Assignee)

Updated

2 years ago
Blocks: 1162107
(Assignee)

Comment 1

2 years ago
Created attachment 8674997 [details]
MozReview Request: Bug 1215586 : Remove icon property from menu addon  r?margaret

Bug 1215586 : Remove icon property from menu addon  r?margaret
Attachment #8674997 - Flags: review?(margaret.leibovic)

Comment 2

2 years ago
Comment on attachment 8674997 [details]
MozReview Request: Bug 1215586 : Remove icon property from menu addon  r?margaret

https://reviewboard.mozilla.org/r/22307/#review20037

r+ with comment addressed.

::: mobile/android/chrome/content/browser.js:2321
(Diff revision 1)
> -            icon: arguments[1],
> +            callback: arguments[1]

We need to be careful here because this code exists to support a deprecated version of the API, and this will break that support.

Let's remove the icon property here, but leave the rest of this code alone. We could also add a deprecation warning for this code path to tell people to use the new options object syntax instead of 3 parameters.
Attachment #8674997 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 3

2 years ago
Comment on attachment 8674997 [details]
MozReview Request: Bug 1215586 : Remove icon property from menu addon  r?margaret

Bug 1215586 : Remove icon property from menu addon  r?margaret

Comment 4

2 years ago
(In reply to Vivek Balakrishnan[:vivek] from comment #3)
> Comment on attachment 8674997 [details]
> MozReview Request: Bug 1215586 : Remove icon property from menu addon 
> r?margaret
> 
> Bug 1215586 : Remove icon property from menu addon  r?margaret

Thanks for the update! Let's land this.
(Assignee)

Comment 5

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/8aff0cae7bfc01ed6674d9536fba68326fbf5caa
Bug 1215586 : Remove icon property from menu addon  r=margaret
https://hg.mozilla.org/mozilla-central/rev/8aff0cae7bfc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.