Closed Bug 1215629 Opened 4 years ago Closed 4 years ago

Remove the nsDebug logger

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

We already fprintf, __android_log_print, etc, we don't need to loop in the logging system as well.

Also note NS_DebugBreak can be called very early in startup and very late in shutdown so this will start to lead to possible issues of logging too early / too late as we improve the mozilla logging module.
Lets go ahead and do this before bug 1174785; it looks like it will make things
easier.
Attachment #8675803 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Blocks: 1174785
Comment on attachment 8675803 [details] [diff] [review]
Remove nsDebug logger

Review of attachment 8675803 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but please post on dev-platform about the removal and wait a day or so before committing to see if anybody yells extremely loudly about it.
Attachment #8675803 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #2)
> Comment on attachment 8675803 [details] [diff] [review]
> Remove nsDebug logger
> 
> Review of attachment 8675803 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me, but please post on dev-platform about the removal and wait a day or so
> before committing to see if anybody yells extremely loudly about it.

Try push including this built fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=472a09e30476

Posted to dev platform earlier today:
https://groups.google.com/forum/#!topic/mozilla.dev.platform/mcsSEX4yJls
https://hg.mozilla.org/mozilla-central/rev/3bc66762ac6e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.