Closed
Bug 1215657
Opened 9 years ago
Closed 9 years ago
make a bunch more of msaa work with proxied accessibles
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
Details
Attachments
(6 files)
1.50 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
1.15 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
1.86 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
1.17 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
827 bytes,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
1.27 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8675089 -
Flags: review?(dbolter)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8675090 -
Flags: review?(dbolter)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8675091 -
Flags: review?(dbolter)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8675092 -
Flags: review?(dbolter)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8675093 -
Flags: review?(dbolter)
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8675095 -
Flags: review?(dbolter)
Updated•9 years ago
|
Assignee: nobody → tbsaunde+mozbugs
Updated•9 years ago
|
Attachment #8675089 -
Flags: review?(dbolter) → review+
Updated•9 years ago
|
Attachment #8675090 -
Flags: review?(dbolter) → review+
Updated•9 years ago
|
Attachment #8675091 -
Flags: review?(dbolter) → review+
Updated•9 years ago
|
Attachment #8675092 -
Flags: review?(dbolter) → review+
Comment 7•9 years ago
|
||
Comment on attachment 8675093 [details] [diff] [review] make AccessibleWrap::accDoDefaultAction work with proxies Review of attachment 8675093 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/windows/msaa/AccessibleWrap.cpp @@ +1138,1 @@ > I think you missed a 'Proxy()->' in that chain?
Comment 8•9 years ago
|
||
Comment on attachment 8675095 [details] [diff] [review] make AccessibleWrap::get_accSelection work with proxies Review of attachment 8675095 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/windows/msaa/AccessibleWrap.cpp @@ +839,5 @@ > + > + uint32_t selectedCount = proxies.Length(); > + for (uint32_t i = 0; i < selectedCount; i++) { > + selectedItems.AppendElement(WrapperFor(proxies[i])); > + } Can you add a comment for why we need to do the loop part?
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to David Bolter [:davidb] from comment #7) > Comment on attachment 8675093 [details] [diff] [review] > make AccessibleWrap::accDoDefaultAction work with proxies > > Review of attachment 8675093 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: accessible/windows/msaa/AccessibleWrap.cpp > @@ +1138,1 @@ > > > > I think you missed a 'Proxy()->' in that chain? yes, oops (In reply to David Bolter [:davidb] from comment #8) > Comment on attachment 8675095 [details] [diff] [review] > make AccessibleWrap::get_accSelection work with proxies > > Review of attachment 8675095 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: accessible/windows/msaa/AccessibleWrap.cpp > @@ +839,5 @@ > > + > > + uint32_t selectedCount = proxies.Length(); > > + for (uint32_t i = 0; i < selectedCount; i++) { > > + selectedItems.AppendElement(WrapperFor(proxies[i])); > > + } > > Can you add a comment for why we need to do the loop part? it seems rather obvious its just converting an array of x to an array of y, because we need an array of y later? There's really nothing at all interesting here that justifies comments.
Comment 10•9 years ago
|
||
Comment on attachment 8675093 [details] [diff] [review] make AccessibleWrap::accDoDefaultAction work with proxies Review of attachment 8675093 [details] [diff] [review]: ----------------------------------------------------------------- OK r+ assuming that fix.
Attachment #8675093 -
Flags: review?(dbolter) → review+
Updated•9 years ago
|
Attachment #8675095 -
Flags: review?(dbolter) → review+
Comment 11•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/afd950962226 https://hg.mozilla.org/integration/mozilla-inbound/rev/7abd3e884ece https://hg.mozilla.org/integration/mozilla-inbound/rev/a95b283ec1e4 https://hg.mozilla.org/integration/mozilla-inbound/rev/e3e04e9203dd https://hg.mozilla.org/integration/mozilla-inbound/rev/1db223020327 https://hg.mozilla.org/integration/mozilla-inbound/rev/d735fd6df22a
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/afd950962226 https://hg.mozilla.org/mozilla-central/rev/7abd3e884ece https://hg.mozilla.org/mozilla-central/rev/a95b283ec1e4 https://hg.mozilla.org/mozilla-central/rev/e3e04e9203dd https://hg.mozilla.org/mozilla-central/rev/1db223020327 https://hg.mozilla.org/mozilla-central/rev/d735fd6df22a
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•