1215669 - Background screenshotting doesn't work if the tabs tray is open

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

From bug 1184344:
> 1) Long press a link to add a tab in the background.
> 2) Open the tab tray before that page loads. You'll see a gray thumbnail.
> 3) Wait a few seconds (or set a breakpoint) until the background page is
> finished loading.
> 4) Tap the thumbnail of the tab you came from, then open the tab tray again.
> The other thumbnail is still gray.

Not sure why having the tabs tray open would interfere with taking tab screenshots.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Could this be a regression of what we landed for https://bugzilla.mozilla.org/show_bug.cgi?id=1184344 ?

Comment 2

[Brian Nicholson (:bnicholson)]

Not a regression, just a case that didn't get fixed there. This is the follow-up for that bug. See https://bugzilla.mozilla.org/show_bug.cgi?id=1184344#c9 and following comments there.

Comment 3

[Richard Newman [:rnewman]]

Might not be an easy fix. Might want to put in default thumbnails as a stopgap.

Comment 4

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1206

Comment 5

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8680956 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1206

Comments in the PR.

Comment 6

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/fa0fd4ee8f847390a15511dcba4d0f2f11483b11