Imagecompare RTL: wait until the screen transition is complete

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: njpark, Assigned: njpark)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Updated

2 years ago
Assignee: nobody → npark
Created attachment 8675150 [details] [review]
[gaia] npark-mozilla:1215673 > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Basically, I was waiting before the beginning of methods, but the waiting should be at the end of the methods, because otherwise take_screeshot() can't take reliable shots.
(Assignee)

Updated

2 years ago
Attachment #8675150 - Flags: review?(martijn.martijn)
(Assignee)

Updated

2 years ago
Blocks: 1215701
(Assignee)

Updated

2 years ago
No longer blocks: 1215701
Comment on attachment 8675150 [details] [review]
[gaia] npark-mozilla:1215673 > mozilla-b2g:master

Looks fine to me. The only thing I wonder about is the many Wait element present/displayed calls. I would think often in those instances, you could just use find_element there.
Attachment #8675150 - Flags: review?(martijn.martijn) → review+
(Assignee)

Comment 4

2 years ago
Merged:
https://github.com/mozilla-b2g/gaia/commit/c12c598f55616c0dd17380d508a08c0a1a4af6ab
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.