Closed Bug 1215686 Opened 4 years ago Closed 4 years ago

Disable ASAN leak reporting on reftests for now

Categories

(Testing :: Reftest, defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Attachment #8675132 - Flags: review?(continuation)
Attachment #8675132 - Flags: review?(continuation) → review+
Fascinating state of affairs: doing that causes jsreftest to be permared, https://treeherder.mozilla.org/logviewer.html#?job_id=15801983&repo=mozilla-inbound, and I suspect will eventually prove to cause reftest-1 to be permared, https://treeherder.mozilla.org/logviewer.html#?job_id=15798381&repo=mozilla-inbound, though it will take a while to know about that because we can't be bothered to run ASan reftest-1 more than once every seven pushes, so a backfill is currently running.

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7d62df943e5e
Assignee: nobody → ehsan
Seems like we're running out of memory:

17:50:43     INFO -  REFTEST TEST-LOAD | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/bugs/632781-verybig.html | 4225 / 6448 (65%)
17:50:50     INFO -  ==1926==ERROR: AddressSanitizer failed to allocate 0x17d7b000 (400011264) bytes of LargeMmapAllocator: 12

But it's not clear what this means:

20:12:12  WARNING -  TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/jsreftest/tests/jsreftest.html?test=test262/intl402/ch09/9.2/9.2.6_4_b.js | application terminated with exit code -9

Andrew, I think you should retry landing this together with the clang 3.7 upgrade when everything is ready.  What do you think?
Flags: needinfo?(continuation)
The standard ASan environment settings reduce the amount of memory it uses, so my guess is that your patch is overwriting some existing environment variables. The right fix then would probably be to track down where it sets those in the first place. I can look into that.
Flags: needinfo?(continuation)
Sorry, I should have realized that when I was reviewing.
Ah makes sense!  Let me test a fix on the try server.
Appending the environment variable fixes things, as expected: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c62f7dff307
https://hg.mozilla.org/mozilla-central/rev/926311d9197d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.