Closed
Bug 1215696
Opened 9 years ago
Closed 9 years ago
update rust mp4parser to v0.1.1
Categories
(Core :: Audio/Video: Playback, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(2 files)
|
3.53 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
|
840 bytes,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
Kinetik's fix for only parsing the 'ftyp' box.
|
Assignee | |
Comment 1•9 years ago
|
||
Good catch figuring out the 'zero tracks' thing. Thanks!
Attachment #8675154 -
Flags: review?(kinetik)
|
|
Assignee | |
Comment 2•9 years ago
|
||
We give the correct answer to the 'street.mp4' test now.
Attachment #8675156 -
Flags: review?(kinetik)
|
||
Updated•9 years ago
|
Attachment #8675154 -
Flags: review?(kinetik) → review+
|
|
||
Updated•9 years ago
|
Attachment #8675156 -
Flags: review?(kinetik) → review+
|
|
||
Comment 3•9 years ago
|
||
BTW: remember to update Cargo.toml to 0.1.1.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a186c0afb34f https://hg.mozilla.org/integration/mozilla-inbound/rev/c1c69af32aa7
Backed out for build bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/ebad4f2326b0 https://treeherder.mozilla.org/logviewer.html#?job_id=15886494&repo=mozilla-inbound
Flags: needinfo?(giles)
|
|
Assignee | |
Updated•9 years ago
|
Flags: needinfo?(giles)
Priority: -- → P2
Hrm, it happened a second time after my backout. Maybe it's some clobber-needed thing?
|
|
Assignee | |
Comment 7•9 years ago
|
||
Trying again with clobber.
https://hg.mozilla.org/integration/mozilla-inbound/rev/17b2c866b454 https://hg.mozilla.org/integration/mozilla-inbound/rev/db739c4c8f97 https://hg.mozilla.org/integration/mozilla-inbound/rev/8c2d6d329985
|
|
Assignee | |
Comment 9•9 years ago
|
||
Looks like the clobber did the trick. We don't have proper dependency generation for rust (patches pending) but I didn't expect that to be a problem because the top-level crate source changed. Strange.
|
||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/17b2c866b454 https://hg.mozilla.org/mozilla-central/rev/db739c4c8f97 https://hg.mozilla.org/mozilla-central/rev/8c2d6d329985
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
|
|
||
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/17b2c866b454 https://hg.mozilla.org/mozilla-central/rev/db739c4c8f97 https://hg.mozilla.org/mozilla-central/rev/8c2d6d329985
|
|
Assignee | |
Comment 12•9 years ago
|
||
(In reply to Matthew Gregan [:kinetik] from comment #3) > BTW: remember to update Cargo.toml to 0.1.1. Thanks, I forgot to do that, and then couldn't upload the package on Friday anyway because of https://github.com/rust-lang/cargo/issues/2063. I moved the tag and pushed the changes yesterday. https://crates.io/crates/mp4parse/0.1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•