If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Changing system wide font size makes history item titles disappear

VERIFIED FIXED

Status

()

Firefox for iOS
Home screen
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: sleroux, Assigned: sleroux)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios1.2+)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
STR:

1. Open History panel with some populated history items
2. Background the app and navigate to Settings -> Accessibility -> Larger Text and increase or decrease the text size
3. Switch back to the app

Expected:

Cell titles still be visible

Actual:

Cell titles become hidden

------

Eventually we'll want to use dynamic type and have the size increase but for now the titles should appear.
(Assignee)

Comment 1

2 years ago
Created attachment 8675149 [details]
IMG_4713.PNG
tracking-fxios: ? → 1.1+
See Also: → bug 1215263
I am moving this to 2.0+ because it is an edge case.

The text disappears when you go "Settings -> Accessibility -> Larger Text" and change the size.

But if you switch back and forth between bookmarks and history, history will correctly reload.

This is annoying and I would like to understand why this is happening and correctly deal with it, but I don't think we should block on it now.

We would block on it if we would render that list badly with non-default text size settings. But that is not the case.
tracking-fxios: 1.1+ → 2.0+
We have a 1.2 flag now, so let's put this there until we figure out scope.
tracking-fxios: 2.0+ → 1.2+
Out of curiosity is iPad affected?
(Assignee)

Comment 5

2 years ago
:AaronMT - Yup it happens on iPad as well.
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 6

2 years ago
Created attachment 8678960 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1194

Seems like modifying the UITableViewCell's default label fonts doesn't work well with dynamic type. UITableViewCell makes assumptions on how to handle it's labels and what font it should and by us change the font it breaks and causes the labels to disappear. I've replaced the default labels with custom ones but overrode the accessors to allow external consumers to remain unchanged. When we want to add support for dynamic type, we should refactor our cell code to use custom label types and listen for dynamic type size notifications to handle the text updates.
Attachment #8678960 - Flags: ui-review?(randersen)
Attachment #8678960 - Flags: review?(sarentz)
Attachment #8678960 - Flags: ui-review?(randersen) → ui-review+
Comment on attachment 8678960 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1194

LGTM
Attachment #8678960 - Flags: review?(sarentz) → review+
(Assignee)

Comment 8

2 years ago
Merged
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Verifying as fixed on Beta 1.2 (1201)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.