Closed Bug 1215702 Opened 4 years ago Closed 4 years ago

remove backend-only CSS properties (marks, orphans, page, size, widows)

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(2 files)

We currently have support for parsing and storage, but not computation, of 5 CSS properties (marks, orphans, page, size, widows).  Three of them were only ever intended to be used in @page rules and *not* in style rules.  Additionally we're violating the CSS specs by parsing them (and accepting them in @supports) when we don't actually support them.

We should just remove the code.  If we ever want to add some support for these properties, we can add the code back, without the complication of having to deal with half-implemented properties in the codebase (causing issues like bug 1215672).
We're violating http://www.w3.org/TR/CSS/#partial by leaving this
implementation in when we don't actually support the properties.

We're also incorrectly parsing marks and size in style rules rather than
@page rules; they were only intended for @page rules.
Attachment #8675171 - Flags: review?(cam)
This is a mechanism that should not exist; any use of it means
nonconformance with http://www.w3.org/TR/CSS/#partial .
Attachment #8675172 - Flags: review?(cam)
(I ran layout/style/test mochitests locally; they pass.)
Blocks: 887520
Attachment #8675171 - Flags: review?(cam) → review+
Attachment #8675172 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/d206c48d9e64
https://hg.mozilla.org/mozilla-central/rev/eabe8e45ac29
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
See Also: → 1363148
You need to log in before you can comment on or make changes to this bug.