Closed Bug 1215730 Opened 9 years ago Closed 9 years ago

Disabling leak checking for screentopng in ASan builds

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: mccr8, Unassigned)

References

Details

Attachments

(1 file)

Under some conditions, the testing infrastructure decides to take a screenshot. Unfortunately, with newer versions of LSan, this will report a leak:

11:43:30     INFO -  TEST-INFO | started process screentopng
11:43:30     INFO -  Xlib:  extension "RANDR" missing on display ":0".
11:43:32     INFO -  =================================================================
11:43:32     INFO -  ==10358==ERROR: LeakSanitizer: detected memory leaks
11:43:32     INFO -  Direct leak of 2032 byte(s) in 1 object(s) allocated from:
11:43:32     INFO -      #0 0x4ad584  (/builds/slave/test/build/tests/bin/screentopng+0x4ad584)
11:43:32     INFO -      #1 0x7fec742bdaa0  (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4daa0)
11:43:32     INFO -  SUMMARY: AddressSanitizer: 2032 byte(s) leaked in 1 allocation(s).
11:43:32     INFO -  TEST-INFO | screentopng: exit 1

This will add unnecessary noise to anybody trying to decipher what actually went wrong. We should make this thing not check for leaks when it runs.
I saw this in a try run that had all leak checking disabled:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cfedd968806
I would guess that this screentopng doesn't have mozglue linked in or something.
This mirrors the code change in bug 1215730, and it seems like the easiest way to disable leak checking. This matches the behavior in our current version of ASan.
Attachment #8677009 - Flags: review?(ted)
(In reply to Andrew McCreight [:mccr8] from comment #3)
> This mirrors the code change in bug 1215730
This should be bug 1216354.
Attachment #8677009 - Flags: review?(ted) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/af6ad83d570f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: