1215730 - Disabling leak checking for screentopng in ASan builds

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Andrew McCreight [:mccr8]]

Under some conditions, the testing infrastructure decides to take a screenshot. Unfortunately, with newer versions of LSan, this will report a leak:

11:43:30     INFO -  TEST-INFO | started process screentopng
11:43:30     INFO -  Xlib:  extension "RANDR" missing on display ":0".
11:43:32     INFO -  =================================================================
11:43:32     INFO -  ==10358==ERROR: LeakSanitizer: detected memory leaks
11:43:32     INFO -  Direct leak of 2032 byte(s) in 1 object(s) allocated from:
11:43:32     INFO -      #0 0x4ad584  (/builds/slave/test/build/tests/bin/screentopng+0x4ad584)
11:43:32     INFO -      #1 0x7fec742bdaa0  (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4daa0)
11:43:32     INFO -  SUMMARY: AddressSanitizer: 2032 byte(s) leaked in 1 allocation(s).
11:43:32     INFO -  TEST-INFO | screentopng: exit 1

This will add unnecessary noise to anybody trying to decipher what actually went wrong. We should make this thing not check for leaks when it runs.

Comment 1

[Andrew McCreight [:mccr8]]

I saw this in a try run that had all leak checking disabled:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cfedd968806
I would guess that this screentopng doesn't have mozglue linked in or something.

Comment 2

[(not currently active) Ted Mielczarek]

Yeah, it's just a simple standalone binary:
https://dxr.mozilla.org/mozilla-central/source/testing/tools/screenshot/moz.build
https://dxr.mozilla.org/mozilla-central/source/testing/tools/screenshot/gdk-screenshot.cpp

Feel free to disable leak checking or fix the leak or whatever. :)

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Disabling leak checking for screentopng in ASan builds.

This mirrors the code change in bug 1215730, and it seems like the easiest way to disable leak checking. This matches the behavior in our current version of ASan.

Comment 4

[Andrew McCreight [:mccr8]]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a92b2576959

Comment 5

[Andrew McCreight [:mccr8]]

(In reply to Andrew McCreight [:mccr8] from comment #3)
> This mirrors the code change in bug 1215730
This should be bug 1216354.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af6ad83d570f

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/af6ad83d570f