Closed
Bug 1215730
Opened 9 years ago
Closed 9 years ago
Disabling leak checking for screentopng in ASan builds
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox44 fixed)
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: mccr8, Unassigned)
References
Details
Attachments
(1 file)
831 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Under some conditions, the testing infrastructure decides to take a screenshot. Unfortunately, with newer versions of LSan, this will report a leak: 11:43:30 INFO - TEST-INFO | started process screentopng 11:43:30 INFO - Xlib: extension "RANDR" missing on display ":0". 11:43:32 INFO - ================================================================= 11:43:32 INFO - ==10358==ERROR: LeakSanitizer: detected memory leaks 11:43:32 INFO - Direct leak of 2032 byte(s) in 1 object(s) allocated from: 11:43:32 INFO - #0 0x4ad584 (/builds/slave/test/build/tests/bin/screentopng+0x4ad584) 11:43:32 INFO - #1 0x7fec742bdaa0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4daa0) 11:43:32 INFO - SUMMARY: AddressSanitizer: 2032 byte(s) leaked in 1 allocation(s). 11:43:32 INFO - TEST-INFO | screentopng: exit 1 This will add unnecessary noise to anybody trying to decipher what actually went wrong. We should make this thing not check for leaks when it runs.
Reporter | ||
Comment 1•9 years ago
|
||
I saw this in a try run that had all leak checking disabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cfedd968806 I would guess that this screentopng doesn't have mozglue linked in or something.
Comment 2•9 years ago
|
||
Yeah, it's just a simple standalone binary: https://dxr.mozilla.org/mozilla-central/source/testing/tools/screenshot/moz.build https://dxr.mozilla.org/mozilla-central/source/testing/tools/screenshot/gdk-screenshot.cpp Feel free to disable leak checking or fix the leak or whatever. :)
Reporter | ||
Comment 3•9 years ago
|
||
This mirrors the code change in bug 1215730, and it seems like the easiest way to disable leak checking. This matches the behavior in our current version of ASan.
Attachment #8677009 -
Flags: review?(ted)
Reporter | ||
Comment 4•9 years ago
|
||
try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a92b2576959
Reporter | ||
Comment 5•9 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #3) > This mirrors the code change in bug 1215730 This should be bug 1216354.
Updated•9 years ago
|
Attachment #8677009 -
Flags: review?(ted) → review+
Reporter | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/af6ad83d570f
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•