Closed
Bug 1215746
Opened 9 years ago
Closed 9 years ago
Remove "force-preflight" fetch mode
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: sicking, Unassigned)
References
Details
Attachments
(1 file)
7.99 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
At least for now it's an internal implementation detail used only by the XHR code, and it doesn't use the "force-preflight" RequestMode enum. So remove it. Let me know if it's ok to make the changes to DBSchema.cpp. Or if we need a database migration? This patch applies on top of the patches in bug 1195167.
Attachment #8675196 -
Flags: review?(bkelly)
Reporter | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f90f84023f8
Comment 2•9 years ago
|
||
Comment on attachment 8675196 [details] [diff] [review] Patch to fix Review of attachment 8675196 [details] [diff] [review]: ----------------------------------------------------------------- I think this is safe as it should not be possible to have a request with this mode in cache.
Attachment #8675196 -
Flags: review?(bkelly) → review+
Reporter | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6af7ffd34eccf1ccaa1409f1f7884f04b6a4ad19 Bug 1215746: Remove RequestMode::Cors_with_forced_preflight. r=bkelly
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6af7ffd34ecc
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•