1215750 - Add telemetry to know when SearchEngineBar label is pressed

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

In bug 1172083, we make the label in the search engine bar open the search engine settings screen.

Anthony, do you think it'd be useful to know when the users click this button?i

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Michael Comella (:mcomella) from comment #0)
> In bug 1172083, we make the label in the search engine bar open the search
> engine settings screen.
> 
> Anthony, do you think it'd be useful to know when the users click this
> button?

YES! If they don't press the button, it might as well not exist!

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I can't help but think we should have used something more discoverable than the magnifying glass. The 3-dot menu image is at least recognizable as tappable.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Michael Comella (:mcomella) from comment #0)
> In bug 1172083, we make the label in the search engine bar open the search
> engine settings screen.
> 
> Anthony, do you think it'd be useful to know when the users click this
> button?i

Sure, data wouldn't hurt. Data could help determine if this visual hint is even necessary, as well as if making it a "button" is useful.

(In reply to Mark Finkle (:mfinkle) from comment #2)
> I can't help but think we should have used something more discoverable than
> the magnifying glass. The 3-dot menu image is at least recognizable as
> tappable.

It was in bug 1172071 where we decided to add this as a "visual cue" since feedback suggested it might be helpful.

"Why are there icons in this bar?" was the question we were looking to answer rather than ACTUALLY provide a shortcut through to Settings.

I just thought it would be a nice little addition if we also made this a short cut to Settings > Customize > Search. I'm not too concerned if our users don't know about it. But, for those poking around, I do think a moment of "aha!" is nice here.

That said, I think a 3-dot overflow icon might be better too. But only if the focus/question we're trying to answer is now different - "how can we show that customize settings page to more users?" rather than "Why are there icons in this bar?" :)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Anthony Lam (:antlam) from comment #3)

> I just thought it would be a nice little addition if we also made this a
> short cut to Settings > Customize > Search. I'm not too concerned if our
> users don't know about it. But, for those poking around, I do think a moment
> of "aha!" is nice here.

We need to be careful about doing work like this. Adding any functionality means we are adding code that needs to be tested and maintained. If no one uses it, we should remove it. If we feel it's useful as a flow to get people to update their search provider, then we should make it work well.

Comment 5

[:Margaret Leibovic]

Christian, let me know if you need help figuring out how to add a telemetry probe.

Comment 6

[Christian Schmitz (:tynn)]

Attachment: bug1215750.patch

I used the event, method and "searchenginebar-settings" extra like proposed via IRC

Comment 7

[:Margaret Leibovic]

Comment on attachment 8679595 [details] [diff] [review]
bug1215750.patch

Review of attachment 8679595 [details] [diff] [review]:
-----------------------------------------------------------------

I have one small nit, but this looks great, thanks!

::: mobile/android/base/home/SearchEngineBar.java
@@ +132,5 @@
>          if (position == 0) {
>              final Intent settingsIntent = new Intent(getContext(), GeckoPreferences.class);
>              GeckoPreferences.setResourceToOpen(settingsIntent, "preferences_search");
>              getContext().startActivity(settingsIntent);
> +            // Telemetry to know when SearchEngineBar label is pressed

We don't need this comment.

Comment 8

[Christian Schmitz (:tynn)]

Attachment: bug1215750.patch

Comment 9

[Christian Schmitz (:tynn)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=55a4abd7412e

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/17cad5502709

Comment 11

[:Margaret Leibovic]

Comment on attachment 8680172 [details] [diff] [review]
bug1215750.patch

Merge came early, so we need to uplift...

Approval Request Comment
[Feature/regressing bug #]: bug 1172083

[User impact if declined]: No telemetry data for search settings button in quick search bar.

[Describe test coverage new/current, TreeHerder]: No automated test, just landed on fx-team.

[Risks and why]: Low-risk, adds telemetry probe.

[String/UUID change made/needed]: none

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/17cad5502709

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8680172 [details] [diff] [review]
bug1215750.patch

The patch looks safe and has been in Nightly for a few days. It seems safe to uplift to Aurora44.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/17cad5502709

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b42fa55211af

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b42fa55211af