When Blake Ross added the "Paste As Quotation" menuitem to the compose context menu he duplicated the id which means that the Edit/Paste As Quotation menuitem doesn't overlay any more. Instead there is a "blank" menuitem.
Seen on linux 2002012308 also.
OS: Windows 95 → All
Oh, and the "Paste as Quotation" context item doesn't update when the menu opens.
IMHO this should go in to 0.9.8 as it is a major regression.
Assignee: ducarroz → neil
Keywords: patch, regression, review
Target Milestone: --- → mozilla0.9.8
Hmm...bleh. Overlays suck for just this reason. How about making a command, though, so we don't have to duplicate the dtd entities and stuff?
commands don't have accesskeys :-( Anyway the fix is in the style of the rest of the context menu.
Commands don't "have" (broadcast?) accesskeys? Now that's a mistake. We should really use a broadcaster but I'll sr= this since Asa is coercing me, and he's a manager, which means he 0w/\/z me.
Filed bug 122201 on the access key issue.
Comment on attachment 66266 [details] [diff] [review] Proposed patch r=timeless [noting blake's sr=]
a=asa (on behalf of drivers) for checkin to 0.9.8
Checked into the 0.9.8 branch.
Is this fixed?
damn I am stupid. It's only on the branch... Sorry forget my former post.
I think it did get checked into the trunk.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Verified on Win2K, Linux, Mac OSX - trunk build 02-04-2002
Status: RESOLVED → VERIFIED
Blake, while I know you would like the context menu to get its labels and accesskeys from commands most of these commands are actually in utilityOverlay.xul and I'm a bit wary of touching that in case it breaks other windows e.g. History.
You need to log in before you can comment on or make changes to this bug.