121582 - "Paste As Quotation" label and command missing from Edit menu

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[[e-mail]]

When Blake Ross added the "Paste As Quotation" menuitem to the compose context
menu he duplicated the id which means that the Edit/Paste As Quotation menuitem
doesn't overlay any more. Instead there is a "blank" menuitem.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Seen on linux 2002012308 also.

Comment 2

[[e-mail]]

Oh, and the "Paste as Quotation" context item doesn't update when the menu opens.

Comment 3

[[e-mail]]

Attachment: Proposed patch

Comment 4

[[e-mail]]

IMHO this should go in to 0.9.8 as it is a major regression.

Comment 5

[Blake Ross]

Hmm...bleh. Overlays suck for just this reason.

How about making a command, though, so we don't have to duplicate the dtd 
entities and stuff?

Comment 6

[[e-mail]]

commands don't have accesskeys :-(

Anyway the fix is in the style of the rest of the context menu.

Comment 7

[Blake Ross]

Commands don't "have" (broadcast?) accesskeys? Now that's a mistake.  We should
really use a broadcaster but I'll sr= this since Asa is coercing me, and he's a
manager, which means he 0w/\/z me.

Comment 8

[[e-mail]]

Filed bug 122201 on the access key issue.

Comment 9

[timeless]

Comment on attachment 66266 [details] [diff] [review]
Proposed patch

r=timeless [noting blake's sr=]

Comment 10

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.8

Comment 11

[Christopher Blizzard (:blizzard)]

Checked into the 0.9.8 branch.

Comment 12

[Jerome Lacoste]

Is this fixed?

Comment 13

[Jerome Lacoste]

damn I am stupid. It's only on the branch... Sorry forget my former post.

Comment 14

[[e-mail]]

I think it did get checked into the trunk.

Comment 15

[Olga]

Verified on Win2K, Linux, Mac OSX - trunk build 02-04-2002 

Comment 16

[[e-mail]]

Blake, while I know you would like the context menu to get its labels and
accesskeys from commands most of these commands are actually in
utilityOverlay.xul and I'm a bit wary of touching that in case it breaks other
windows e.g. History.