1215850 - duplicate entity shouldRestartTitle in preferences.properties: remove one instance

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v1

https://hg.mozilla.org/mozilla-central/rev/0ea13f8b1e77 added shouldRestartTitle to preferences.properties, but it already had this one. Translations are identical http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=shouldRestartTitle
The older one is for restarting to enable a 'feature'.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8675315 [details] [diff] [review]
patch, v1

Review of attachment 8675315 [details] [diff] [review]:
-----------------------------------------------------------------

shouldRestartTitle is referenced in main.js, privacy.js, and blocklists.js. blocklistChangeRequiresRestart is referenced in blocklists.js. We can't remove one of them without updating references to it.

It seems to me that blocklistChangeRequiresRestart was intended to give more details as to why Firefox should be restarted. As of now, it looks like the dialog will have [title=Restart Firefox, message=Restart Firefox].

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> blocklistChangeRequiresRestart is referenced in blocklists.js. We can't
> remove one of them without updating references to it.
The string doesn't change any functionality. shouldRestartTitle has been defined twice in preferences.properties:
https://dxr.mozilla.org/mozilla-central/rev/d53a52b39a95dced722cca90ac74529b66dd5253/browser/locales/en-US/chrome/browser/preferences/preferences.properties#53
https://dxr.mozilla.org/mozilla-central/rev/d53a52b39a95dced722cca90ac74529b66dd5253/browser/locales/en-US/chrome/browser/preferences/preferences.properties#170
Both have the value "Restart %S". So this won't change the behavior of Firefox. The removal of the duplicate shall prevent issues in localization tools and one translation overriding the other one in case someone translated them different.

> It seems to me that blocklistChangeRequiresRestart was intended to give more
> details as to why Firefox should be restarted. As of now, it looks like the
> dialog will have [title=Restart Firefox, message=Restart Firefox].
Because the patch doesn't touch blocklistChangeRequiresRestart, the dialog will remain unchanged.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8675315 [details] [diff] [review]
patch, v1

Review of attachment 8675315 [details] [diff] [review]:
-----------------------------------------------------------------

Okay, thanks for the reply. I misunderstood the goal of this patch. This change looks fine to me.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4437a28d2e47

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4437a28d2e47