Closed
Bug 1215899
Opened 9 years ago
Closed 9 years ago
Suppress clang and gcc warnings in gfx/skia
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
Attachments
(1 file)
|
15.17 KB,
patch
|
gw280
:
review+
|
Details | Diff | Splinter Review |
Suppress the following clang and gcc warnings in moz.build and generate_mozbuild.py: -Wimplicit-fallthrough // clang warning about switch cases that fall through without a MOZ_FALLTHROUGH annotations -Wmaybe-uninitialized // gcc warning that reports way too many false positives. -Wsign-compare gfx/skia/skia/src/core/SkClipStack.cpp:694:17 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkDraw.cpp:715:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkImageInfo.cpp:53:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:113:31 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:113:49 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:114:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:114:31 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:114:49 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:115:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:115:31 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:115:49 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:116:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:116:31 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:116:49 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:117:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:117:31 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:117:49 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:118:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:118:31 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:118:49 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:119:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:119:31 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:119:49 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:120:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:120:31 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:120:49 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:121:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:121:31 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:121:49 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:122:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:122:31 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:122:49 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkMath.cpp:124:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:19:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:20:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:21:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:22:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:23:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:24:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:25:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:26:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:27:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:28:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:29:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:30:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:31:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:32:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:33:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:42:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:43:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:44:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:45:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:46:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:47:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:48:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:49:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:50:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:51:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:52:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:53:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:54:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:55:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPackBits.cpp:56:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPath.cpp:412:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPath.cpp:1957:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPath.cpp:2036:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPath.cpp:2447:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPathRef.cpp:315:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkPathRef.cpp:386:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/core/SkTextMapStateProc.h:69:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/effects/Sk1DPathEffect.cpp:130:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/effects/SkBlurMaskFilter.cpp:274:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/effects/SkBlurMaskFilter.cpp:282:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/effects/SkColorFilters.cpp:150:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/GrAAConvexPathRenderer.cpp:204:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/GrBlend.cpp:70:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/GrBlend.cpp:82:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/GrBlend.cpp:94:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/GrBlend.cpp:104:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/GrClipMaskManager.cpp:137:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/GrDefaultPathRenderer.cpp:401:17 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/GrDefaultPathRenderer.cpp:421:17 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/GrDrawTarget.cpp:359:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/GrDrawTarget.cpp:376:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/GrGpu.cpp:291:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/effects/GrRRectEffect.cpp:698:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/gl/GrGLShaderBuilder.cpp:576:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/gl/GrGpuGL.cpp:1855:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/sfnt/SkOTTable_name.cpp:476:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/utils/SkCullPoints.cpp:133:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/skia/skia/src/gpu/GrAAConvexPathRenderer.cpp:697:5 [-Wmaybe-uninitialized] 'vCount' may be used uninitialized in this function gfx/skia/skia/src/gpu/GrDrawTarget.cpp:367:5 [-Wmaybe-uninitialized] 'maxValidVertex' may be used uninitialized in this function gfx/skia/skia/src/gpu/GrDrawTarget.cpp:384:9 [-Wmaybe-uninitialized] 'maxValidIndex' may be used uninitialized in this function gfx/skia/skia/src/opts/SkBlitMask_opts_arm_neon.cpp:175:79 [-Wmaybe-uninitialized] 'vcolR' may be used uninitialized in this function gfx/skia/skia/src/opts/SkBlitMask_opts_arm_neon.cpp:176:77 [-Wmaybe-uninitialized] 'vcolG' may be used uninitialized in this function gfx/skia/skia/src/opts/SkBlitMask_opts_arm_neon.cpp:177:77 [-Wmaybe-uninitialized] 'vcolB' may be used uninitialized in this function gfx/skia/skia/src/opts/SkBlitMask_opts_arm_neon.cpp:235:47 [-Wmaybe-uninitialized] 'vcolA' may be used uninitialized in this function gfx/skia/skia/src/opts/SkBlitMask_opts_arm_neon.cpp:240:79 [-Wmaybe-uninitialized] 'vcolR' may be used uninitialized in this function gfx/skia/skia/src/opts/SkBlitMask_opts_arm_neon.cpp:241:77 [-Wmaybe-uninitialized] 'vcolG' may be used uninitialized in this function gfx/skia/skia/src/opts/SkBlitMask_opts_arm_neon.cpp:242:77 [-Wmaybe-uninitialized] 'vcolB' may be used uninitialized in this function gfx/skia/skia/src/ports/SkFontHost_FreeType_common.cpp:83:39 [-Wsign-compare] comparison between signed and unsigned integer expressions gfx/skia/skia/src/ports/SkFontHost_FreeType_common.cpp:86:40 [-Wsign-compare] comparison between signed and unsigned integer expressions gfx/skia/skia/src/ports/SkFontHost_FreeType_common.cpp:116:47 [-Wsign-compare] comparison between signed and unsigned integer expressions gfx/skia/skia/src/ports/SkFontHost_FreeType_common.cpp:139:48 [-Wsign-compare] comparison between signed and unsigned integer expressions gfx/skia/skia/src/ports/SkFontHost_FreeType_common.cpp:180:38 [-Wsign-compare] comparison between signed and unsigned integer expressions gfx/skia/skia/src/ports/SkFontHost_FreeType_common.cpp:181:39 [-Wsign-compare] comparison between signed and unsigned integer expressions
Attachment #8675365 -
Flags: review?(gwright)
|
||
Updated•9 years ago
|
Attachment #8675365 -
Flags: review?(gwright) → review+
|
||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/26e8885719b6
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•