Closed Bug 1215901 Opened 4 years ago Closed 4 years ago

Suppress clang and gcc warnings in gfx/angle

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch suppress-angle-warnings.patch (obsolete) — Splinter Review
I can submit a pull request to add these warning suppressions to generate_mozbuild.py in the upstream mozilla/angle repo:

https://github.com/mozilla/angle/blob/mozilla/generate_mozbuild.py

gfx/angle/src/compiler/translator/ASTMetadataHLSL.cpp:69:10 [-Winconsistent-missing-override] 'visitLoop' overrides a member function but is not marked 'override'
gfx/angle/src/compiler/translator/ASTMetadataHLSL.cpp:75:10 [-Winconsistent-missing-override] 'visitSelection' overrides a member function but is not marked 'override'
gfx/angle/src/compiler/translator/ASTMetadataHLSL.cpp:90:15 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
gfx/angle/src/compiler/translator/ASTMetadataHLSL.cpp:336:10 [-Winconsistent-missing-override] 'visitLoop' overrides a member function but is not marked 'override'
gfx/angle/src/compiler/translator/ParseContext.cpp:993:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
gfx/angle/src/compiler/translator/ParseContext.cpp:3472:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
gfx/angle/src/compiler/translator/ParseContext.cpp:3603:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
gfx/angle/src/compiler/translator/ParseContext.cpp:3612:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
gfx/angle/src/compiler/translator/glslang_tab.cpp:2239:15 [-Wunreachable-code] code will never be executed
gfx/angle/src/compiler/translator/glslang_tab.cpp:5004:6 [-Wunreachable-code] code will never be executed
Attachment #8675367 - Flags: review?(jgilbert)
Also suppress clang and gcc's -Wshadow warnings and gcc's -Wshadow-local and -Wshadow-compatible-local warnings. These -Wshadow* warnings are not enabled by default, but I am slowly fixing them in other bugs.

gfx/angle/src/common/blocklayout.h:29:25 [-Wshadow] declaration shadows a field of 'sh::BlockMemberInfo'
gfx/angle/src/common/blocklayout.h:29:37 [-Wshadow] declaration shadows a field of 'sh::BlockMemberInfo'
gfx/angle/src/common/blocklayout.h:29:54 [-Wshadow] declaration shadows a field of 'sh::BlockMemberInfo'
gfx/angle/src/common/blocklayout.h:29:73 [-Wshadow] declaration shadows a field of 'sh::BlockMemberInfo'
gfx/angle/src/common/mathutil.h:28:19 [-Wshadow] declaration shadows a field of 'gl::Vector4'
gfx/angle/src/common/mathutil.h:28:28 [-Wshadow] declaration shadows a field of 'gl::Vector4'
gfx/angle/src/common/mathutil.h:28:37 [-Wshadow] declaration shadows a field of 'gl::Vector4'
gfx/angle/src/common/mathutil.h:28:46 [-Wshadow] declaration shadows a field of 'gl::Vector4'

gfx/angle/src/compiler/translator/Compiler.cpp:421:63 [-Wshadow] declaration shadows a field of 'TCompiler'
gfx/angle/src/compiler/translator/DetectCallDepth.cpp:36:9 [-Wshadow] declaration shadows a field of 'DetectCallDepth'
gfx/angle/src/compiler/translator/DetectCallDepth.cpp:72:45 [-Wshadow] declaration shadows a field of 'DetectCallDepth'
gfx/angle/src/compiler/translator/IntermNode.h:695:27 [-Wshadow] declaration shadows a field of 'TIntermTraverser'
gfx/angle/src/compiler/translator/IntermNode.h:695:49 [-Wshadow] declaration shadows a field of 'TIntermTraverser'
gfx/angle/src/compiler/translator/IntermNode.h:695:71 [-Wshadow] declaration shadows a field of 'TIntermTraverser'
gfx/angle/src/compiler/translator/IntermNode.h:696:27 [-Wshadow] declaration shadows a field of 'TIntermTraverser'
gfx/angle/src/compiler/translator/OutputGLSLBase.cpp:558:26 [-Wshadow] declaration shadows a local variable
gfx/angle/src/compiler/translator/ParseContext.cpp:1065:91 [-Wshadow] declaration shadows a field of 'TParseContext'
gfx/angle/src/compiler/translator/ParseContext.h:28:171 [-Wshadow] declaration shadows a field of 'TParseContext'
gfx/angle/src/compiler/translator/PoolAlloc.h:45:24 [-Wshadow] declaration shadows a field of 'TAllocation'
gfx/angle/src/compiler/translator/PoolAlloc.h:45:45 [-Wshadow] declaration shadows a field of 'TAllocation'
gfx/angle/src/compiler/translator/PoolAlloc.h:159:26 [-Wshadow] declaration shadows a field of 'TPoolAllocator::tHeader'
gfx/angle/src/compiler/translator/PoolAlloc.h:159:43 [-Wshadow] declaration shadows a field of 'TPoolAllocator::tHeader'
gfx/angle/src/compiler/translator/ShaderVars.cpp:102:21 [-Wshadow] declaration shadows a local variable
gfx/angle/src/compiler/translator/StructureHLSL.cpp:277:22 [-Wshadow] declaration shadows a local variable
gfx/angle/src/compiler/translator/Types.cpp:181:16 [-Wshadow] declaration shadows a field of 'TType'

gfx/angle/src/compiler/translator/OutputGLSLBase.cpp:539:69 [-Wshadow-local] shadowed declaration is here
gfx/angle/src/compiler/translator/OutputGLSLBase.cpp:558:26 [-Wshadow-local] declaration of 'TIntermNode* node' shadows a parameter

gfx/angle/src/compiler/translator/ShaderVars.cpp:89:17 [-Wshadow-compatible-local] shadowed declaration is here
gfx/angle/src/compiler/translator/ShaderVars.cpp:102:21 [-Wshadow-compatible-local] declaration of 'topName' shadows a previous local
gfx/angle/src/compiler/translator/StructureHLSL.cpp:200:49 [-Wshadow-compatible-local] shadowed declaration is here
gfx/angle/src/compiler/translator/StructureHLSL.cpp:277:22 [-Wshadow-compatible-local] declaration of 'const TType& type' shadows a parameter
Attachment #8675367 - Attachment is obsolete: true
Attachment #8675367 - Flags: review?(jgilbert)
Attachment #8675445 - Flags: review?(jgilbert)
Attachment #8675445 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/2d225edfccbf
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.