Closed
Bug 1216020
Opened 9 years ago
Closed 9 years ago
Comment all ALLOW_COMPILER_WARNINGS lines
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox44 fixed)
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
|
25.12 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
This will hopefully prevent confusion like that in bug 1215903.
|
Assignee | |
Comment 1•9 years ago
|
||
I'm not certain about those GYP_DIRS. Perhaps they should instead have "XXX: We should fix these warnings" messages.
Attachment #8675495 -
Flags: review?(mh+mozilla)
|
||
Updated•9 years ago
|
Attachment #8675495 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/92eb00ee19771b8ea7027d10acec971430a69143 Bug 1216020 - Comment all ALLOW_COMPILER_WARNINGS lines. r=glandium.
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/92eb00ee1977
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•