1216042 - [Browser] Do not show default icon on pin site badge if no icon provided by the site

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

Description

[Alison Shiue]

+++ This bug was initially created as a clone of Bug #1204427 +++

Hi Alberto,

I tried with the latest build, but found that the default icon still not show on URL bar and pin site section of pin dialog.

Could you please help to check it? Thank you.


STR:
1. Go to http://mozilla-twqa.github.io/QA-Dashboard/ where do not provide site icons
2. Check URL bar
3. Tap overflow menu->Pin, to check the site icon on pin site section

Expected result:
1. Default icon shows correctly on both URL bar

Actual result:
1. In step 2, dotted circle shows on URL bar
2. In step 3, no icon shows on pin site section of pin dialog


Build info:
[Flame]
Build ID               20151018150205
Gaia Revision          f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date              2015-10-16 13:00:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151018.183443
Firmware Date          Sun Oct 18 18:34:55 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151018193102
Gaia Revision          f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date              2015-10-16 13:00:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151018.185054
Firmware Date          Sun Oct 18 18:51:02 UTC 2015
Bootloader             s1

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1216042-pin-icon > mozilla-b2g:master

Comment 2

[Alberto Pastor [:albertopq]]

Comment on attachment 8675546 [details] [review]
[gaia] albertopq:1216042-pin-icon > mozilla-b2g:master

Another quick one? Thanks!

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8675546 [details] [review]
[gaia] albertopq:1216042-pin-icon > mozilla-b2g:master

r+ :-)

Comment 4

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/375e7d535e7c4e625f2e1cb81fabe6a08e71949d

Comment 5

[Alison Shiue]

Verified on

[Flame]
Build ID               20151019150205
Gaia Revision          a87f947366c2e044bd6336e1982419ac45378969
Gaia Date              2015-10-19 15:22:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151019.182947
Firmware Date          Mon Oct 19 18:29:58 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151019205841
Gaia Revision          a87f947366c2e044bd6336e1982419ac45378969
Gaia Date              2015-10-19 15:22:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151019.201730
Firmware Date          Mon Oct 19 20:17:38 UTC 2015
Bootloader             s1