1216047 - Tapping on the "Installation complete| ADD-ONS" toast notification should open the add-on manager

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: LG G4 (Android 5.1)
Build: Firefox for Android 44.0a1 (2015-10-18)

Steps to reproduce:
1. Go to https://addons.mozilla.org/en-US/android and install an add-on
2. From the "Installation complete| ADD-ONS" toast tap on the "ADD-ONS" button to switch to the add-on manager.

Expected results:
- Add-on manager is opened and all installed add-ons are displayed

Actual results:
- Nothing happens

Note:
-regression
good build: 14-10
bad build: 15-10
pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2387ada864282880d3a498d643abe3d8b887ee59&tochange=e193b4da0a8c1025aa76a403c64663ff1cd41709

Bug 1194182 - Implement switch-to-tab for add-on toast notification

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: fix-selectoraddtab v0.1

Simple fix to getTabWithURL

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: test-selectoraddtab v0.1

Simple test for selectOrAddTab. It does:
1. Tests the "add" code path
2. Tests the "select" code path
3. Tests the "select" code path using the "startsWith" code path

Comment 3

[:Margaret Leibovic]

Comment on attachment 8675903 [details] [diff] [review]
fix-selectoraddtab v0.1

Review of attachment 8675903 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/browser.js
@@ +1317,5 @@
>     *           to have about:downloads match about:downloads#123.
>     * @return the tab with the given URL, or null if no such tab exists
>     */
>    getTabWithURL: function getTabWithURL(aURL, aOptions) {
> +    aOptions = aOptions || {};

See, if you implemented my idea to simplify these code paths to get rid of the options parameter, this wouldn't be a problem! :)

Comment 4

[:Margaret Leibovic]

Comment on attachment 8675904 [details] [diff] [review]
test-selectoraddtab v0.1

Review of attachment 8675904 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/tests/browser/chrome/test_selectoraddtab.html
@@ +83,5 @@
> +    // Check that about:blank is selected
> +    is(BrowserApp.selectedBrowser, browserBlank, "about:blank is selected.");
> +
> +    // Use selectOrAddTab to select the existing tab using the startsWith flag
> +    BrowserApp.selectOrAddTab(kTestPage, { selected: true, parentId: BrowserApp.selectedTab.id }, { startsWith: kTestPage }).browser;

Maybe you should add a hash to `kTestPage` to test the `startsWith` behavior?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to :Margaret Leibovic from comment #4)

> > +    // Use selectOrAddTab to select the existing tab using the startsWith flag
> > +    BrowserApp.selectOrAddTab(kTestPage, { selected: true, parentId: BrowserApp.selectedTab.id }, { startsWith: kTestPage }).browser;
> 
> Maybe you should add a hash to `kTestPage` to test the `startsWith` behavior?

That's not a bad idea, but I'm happy with this level of testing for now. Executing the "startsWith" code path does execute different code - a URL string comparison instead of a nsIURL comparison.

Try looks green in the 'c' tests https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5ea3108f796

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3caf2963fc0a
https://hg.mozilla.org/integration/fx-team/rev/a47bbb36dbae

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3caf2963fc0a
https://hg.mozilla.org/mozilla-central/rev/a47bbb36dbae

Comment 8

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed using:
Device: Prestigio PSP5508 (Android 4.4.2)
Build: Firefox for Android 44.0a1 (2015-10-21)

After tapping the "ADD-ONS" button from the toast notification, add-on manager is opened and all installed add-ons are displayed.