1216075 - [Add-ons]there is no version information in Add-on description screen.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Aries_v2.5_ver.png

[1.Description]:
[Aries KK][Flame KK][v2.5][Settings]Launch Settings app, select  Add-ons and tap an Add-on description screen and observe,  there is no version information. 
Time: 15:46
See attachments: logcat_ver.txt and  Aries_v2.5_ver.png


[2.Testing Steps]: 
1. Launch Settings app 
2. Tap Add-ons 
3. Tap an  Add-on description screen and observe.

[3.Expected Result]: 
In step 3, the screen should contain version information.

[4.Actual Result]: 
In step 3, there is no version information. 

[5.Reproduction build]: 
Aries KK v2.5(Affected)
Build ID               20151018193102
Gaia Revision          f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date              2015-10-16 13:00:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151018.185054
Firmware Date          Sun Oct 18 18:51:02 UTC 2015
Bootloader             s1

Flame KK v2.5(Affected)
Build ID               20151018150205
Gaia Revision          f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date              2015-10-16 13:00:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151018.183443
Firmware Date          Sun Oct 18 18:34:55 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0


[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
16672

[8.NOTE]
1. Version information of both enabled & disabled Add-ons are not displayed.

Comment 1

[Autumn.Qiu(Leave from Mozilla)]

Attachment: logcat_ver.txt

Comment 2

[Mike Lien[:mlien]]

This issue refers to the UX spec from: https://drive.google.com/drive/folders/0B-CK_pGGzS6AfmpMYVc1eC1qLWc2NnN4bkZHejJsTEtsQndEVzdyeTR4QnBxd1BDU1FCUU0

Comment 3

[Mike Lien[:mlien]]

[Blocking Requested - why for this release]:
Mismatch with UX spec

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Versions of an add-on are pretty important I think. Marking as blocker.

Yura, do you have time to take a look at this? Should be a quick fix I believe.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1216075 > mozilla-b2g:master

Comment 6

[[e-mail]]

Comment on attachment 8678687 [details] [review]
[gaia] gasolin:issue-1216075 > mozilla-b2g:master

I made the detail page can show addon version, Currently it only shows build-in test addons version.


The limitation is its not work for the addons installed from the marketplace. It might be caused by some gecko issues Scott found in Bug 1215546 (will describe in below comment)

Comment 7

[[e-mail]]

Scott found when addon list successfully received the oninstall event and the listview is ready to reflesh the list. But the addon related information is not ready yet (can't get from the manifest). After adding some delay on oninstall event handler, the manifest can be processed correctly (but the delay time depends on device). Therefore it's more reasonable to fix on gecko side.

For this issue I've checked the build-in addon, addon from marketplace, addon installed from web IDE. The later two does not shown manifest.version correctly thought they have defined version in their manifest.

Those two issues might be related to the change of web extensions api, will file issues accordingly.

Comment 8

[Ken Chang[:kenkai]]

Polish bug.

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8678687 [details] [review]
[gaia] gasolin:issue-1216075 > mozilla-b2g:master

Hi Fred, I think it would be best to get some UX feedback on this. A couple of comments that I have are:

* Just the number of the version is not intuitive, it should best have a label: e.g. Current Version. Otherwise some users might think it's average rating and what not.

* It feels like it should have lower order priority than description for example. Version feels like an additional bit of information, far less relevant to the user than the description for example.

* Bold font is not used on details page and feel like it draws unnecessary attention to the version number.

Again most of the above is subjective and I would love to hear some feedback from UX. If you feel strongly about the way it's implemented in the PR, just reflag me again.

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [ux spec] Add-ons v1.3

Thanks for the detailed review Yura. I am attaching the spec for reference, which I think Fred is following. If we are, let's just do what's in the spec and fix any additional UX issues in the next release.

Also, since Ken believes this is a polish bug, and the "real" fix probably involves some gecko work, I'm ok with unblocking on this one. I'll leave that up to Fred and Yura.

Comment 11

[[e-mail]]

Attachment: detail page spec

The version style in detail page is followed with UX spec (without any of my preference), so I guest its UX blessed. 

If the version info is essential we could land it and polish it later with UX involvement.

Comment 12

[[e-mail]]

Comment on attachment 8678687 [details] [review]
[gaia] gasolin:issue-1216075 > mozilla-b2g:master

I found the previous patch does not tweak the color of version string, and missing the 'v' before version (should be v1.x)

So it might looks more acceptable now :-/

Comment 13

[[e-mail]]

Attachment: visual afer patch

The screen looks and feel after patch

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Fred Lin [:gasolin] from comment #11)
> If the version info is essential we could land it and polish it later with
> UX involvement.

Note, I believe version info is essential in the case that a certain version of an add-on is known to have security problems, the user needs to be able to know if they are vulnerable.

Comment 15

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8678687 [details] [review]
[gaia] gasolin:issue-1216075 > mozilla-b2g:master

Looks good thanks. I'm on board with polishing it down the road.

Comment 16

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/d0f5108bb3a9a59e48fed2bc7ae1bc0612777a57

thanks!

Comment 17

[Shally Li（leave from Mozilla）]

Hi Autumn,

Could you please help to verify this bug? 

Thank you.

Comment 18

[Autumn.Qiu(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Aries KK v2.6 and Flame KK v2.6 512mb by the STR in comment 0.

Actual results: Tap an Add-on description screen, it contains version information.
See attachment: Verified_Aries_KK_v2.6_addt.png
Reproduce rate: 0/10

Device: Aries KK 2.6 (master)(Pass)
Build ID               20151104004249
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151104.000116
Firmware Date          Wed Nov  4 00:01:24 UTC 2015
Bootloader             s1


Device: Flame KK 2.6 512mb (master)(Pass)
Build ID               20151103150203
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151103.182550
Firmware Date          Tue Nov  3 18:26:03 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 19

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Verified_Aries_KK_v2.6_addt.png

Comment 20

[Autumn.Qiu(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Aries KK v2.5 and Flame KK v2.5 512mb by the STR in comment 0.

Actual results: Tap an Add-on description screen, it contains version information.
See attachment: Verified_Aries_KK_v2.5_addt.png
Reproduce rate: 0/10

Device: Aries KK 2.5(Pass)
Build ID               20151107112205
Gaia Revision          577948202ae12154524a2bd2bd6d467838ad50b8
Gaia Date              2015-11-07 10:00:59
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae7b8b1fd9e1504347b938820f99d75058049386
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151107.104119
Firmware Date          Sat Nov  7 10:41:27 UTC 2015
Bootloader             s1

Device: Flame KK 2.5 512MB(Pass)
Build ID               20151108004501
Gaia Revision          577948202ae12154524a2bd2bd6d467838ad50b8
Gaia Date              2015-11-07 10:00:59
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae7b8b1fd9e1504347b938820f99d75058049386
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151108.045623
Firmware Date          Sun Nov  8 04:56:35 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 21

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Verified_Aries_KK_v2.5_addt.png

Comment 22

[Jacqueline Savory [:jsavory] UX]

I apologize for the delay, this matches the spec and looks good to me. Visual might have refinements, but we can open another bug for that if needed.