Closed Bug 1216078 Opened 4 years ago Closed 4 years ago

Mozreview should not post full patch description each time a patch gets updated

Categories

(MozReview Graveyard :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: dminor)

References

Details

Attachments

(1 file)

As you can see on bug 1211489 it can be very distracting if you update a patch multiple times which itself has a long description set. Instead of posting the full description each time, we may be able to only post the changelog? Right now its not obvious what has been changed exactly when simply following the bug comments.
I believe we have plans in the works to reduce the amount of information we mirror to bugzilla in general, but there's no reason we can't make this better now.
Assignee: nobody → dminor
Blocks: 1212358
Priority: -- → P3
mozreview: only mirror full commit description to bugzilla when first publishing (bug 1216078) r?mcote

At the moment we create a comment containing the full commit description each
time a commit is updated. If people write detailed commit messages, this ends
up taking a large amount of space when looking at the bug.

With these changes, we only create a comment with the full commit description
on the first change. The comment for each subsequent update to a commit only
contains a link to the review.
Attachment #8675862 - Flags: review?(mcote)
That means Mozreview currently doesn't support incremental comments? To follow the process of follow-up commits that would be kinda helpful.
(In reply to Henrik Skupin (:whimboo) from comment #3)
> That means Mozreview currently doesn't support incremental comments? To
> follow the process of follow-up commits that would be kinda helpful.

I am trying to minimize the amount of information that is duplicated back to bugzilla.

I'm sorry, I'm not sure what additional information you're looking for. The list of affected files for the commit?
Status: NEW → ASSIGNED
(In reply to Dan Minor [:dminor] from comment #4)
> I'm sorry, I'm not sure what additional information you're looking for. The
> list of affected files for the commit?

Just the ability to specify some lines for changes since the last commit for this patch. So when you see the comment it is clear what has been changed since the last commit.
(In reply to Henrik Skupin (:whimboo) from comment #5)
> (In reply to Dan Minor [:dminor] from comment #4)
> > I'm sorry, I'm not sure what additional information you're looking for. The
> > list of affected files for the commit?
> 
> Just the ability to specify some lines for changes since the last commit for
> this patch. So when you see the comment it is clear what has been changed
> since the last commit.

That makes sense but we don't have a direct way of capturing that information. My original thought was to look at the interdiff and list the files that have changed, but I think in general we're trying to limit the amount of review information that goes back to bugzilla.
Comment on attachment 8675862 [details]
MozReview Request: mozreview: only mirror full commit description to bugzilla when first publishing (bug 1216078) r=mcote

https://reviewboard.mozilla.org/r/22467/#review20139

::: pylib/rbbz/rbbz/extension.py:287
(Diff revision 1)
> +        comment = 'Review requested updated, see: %s\n\n' % get_obj_url(review_request)

This would be even cooler if we displayed a link to the interdiff.

Followup?
Attachment #8675862 - Flags: review+
https://reviewboard.mozilla.org/r/22467/#review20139

> This would be even cooler if we displayed a link to the interdiff.
> 
> Followup?

Good idea, I'll do that instead.
Comment on attachment 8675862 [details]
MozReview Request: mozreview: only mirror full commit description to bugzilla when first publishing (bug 1216078) r=mcote

mozreview: only mirror full commit description to bugzilla when first publishing (bug 1216078) r?mcote

At the moment we create a comment containing the full commit description each
time a commit is updated. If people write detailed commit messages, this ends
up taking a large amount of space when looking at the bug.

With these changes, we only create a comment with the full commit description
on the first change. The comment for each subsequent update to a commit only
contains a link to the interdiff.
Comment on attachment 8675862 [details]
MozReview Request: mozreview: only mirror full commit description to bugzilla when first publishing (bug 1216078) r=mcote

https://reviewboard.mozilla.org/r/22467/#review20153

::: pylib/rbbz/rbbz/extension.py:288
(Diff revision 2)
> +        comment = 'Review request updated, see: %sdiff/%d-%d/\n' % (

Semicolon, not comma.  Also maybe mention this is an interdiff link ("see interdiff" or "see changes in this revision" or the like).

::: pylib/rbbz/rbbz/extension.py:289
(Diff revision 2)
> +                  get_obj_url(review_request),
> +                  diffset_count,
> +                  diffset_count + 1)

Weird indentation.
Attachment #8675862 - Flags: review?(mcote)
Attachment #8675862 - Flags: review?(mcote)
Comment on attachment 8675862 [details]
MozReview Request: mozreview: only mirror full commit description to bugzilla when first publishing (bug 1216078) r=mcote

mozreview: only mirror full commit description to bugzilla when first publishing (bug 1216078) r?mcote

At the moment we create a comment containing the full commit description each
time a commit is updated. If people write detailed commit messages, this ends
up taking a large amount of space when looking at the bug.

With these changes, we only create a comment with the full commit description
on the first change. The comment for each subsequent update to a commit only
contains a link to the interdiff.
Comment on attachment 8675862 [details]
MozReview Request: mozreview: only mirror full commit description to bugzilla when first publishing (bug 1216078) r=mcote

https://reviewboard.mozilla.org/r/22467/#review20607
Attachment #8675862 - Flags: review?(mcote) → review+
Comment on attachment 8675862 [details]
MozReview Request: mozreview: only mirror full commit description to bugzilla when first publishing (bug 1216078) r=mcote

mozreview: only mirror full commit description to bugzilla when first publishing (bug 1216078) r=mcote

At the moment we create a comment containing the full commit description each
time a commit is updated. If people write detailed commit messages, this ends
up taking a large amount of space when looking at the bug.

With these changes, we only create a comment with the full commit description
on the first change. The comment for each subsequent update to a commit only
contains a link to the interdiff.
Attachment #8675862 - Attachment description: MozReview Request: mozreview: only mirror full commit description to bugzilla when first publishing (bug 1216078) r?mcote → MozReview Request: mozreview: only mirror full commit description to bugzilla when first publishing (bug 1216078) r=mcote
Thanks!

https://hg.mozilla.org/hgcustom/version-control-tools/rev/608df44d9ff3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.