Closed Bug 1216083 Opened 9 years ago Closed 9 years ago

[Pin the Web]Browser does not open a new window for pin site which is not in scope.

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.5+, b2g-v2.2 disabled, b2g-master affected)

VERIFIED FIXED
blocking-b2g 2.5+
Tracking Status
b2g-v2.2 --- disabled
b2g-master --- affected

People

(Reporter: xiongfuchao, Assigned: apastor)

Details

(Whiteboard: [systemsfe])

Attachments

(3 files)

Attached file logcat_0543.txt
[1.Description]:
[Aries KK v2.5][Pin the Web]When the website "http://alison-shiue.github.io/without\_manifest/icon\_1.html" is opened in background, if user opens another web site which is not in scope "http://alison-shiue.github.io/with\_manifest/start\_url.html " via tapping the pined icon in homescreen, browser will open the first web site that you opened.  
Found time:05:43
See attachment:Arieskk_v2.5.3gp & logcat_0543.txt

[2.Testing Steps]: 
Initial Condition:  Prerequisite: Enable Pinning the Web on Settings > Developer  
1. Go to http://alison-shiue.github.io/with\_manifest/link\_manifest.html, and pin this site via overflow menu(...) -> pin site section 
2. Close current window and go to homescreen 
3. Tap browser icon to open a new window, and navigate to http://alison-shiue.github.io/without\_manifest/icon\_1.html which is not in scope 
4. Go back to homescreen and tap the pinned icon 

[3.Expected Result]: 
4. Browser should open another window whose start page is http://alison-shiue.github.io/with\_manifest/start\_url.html 

[4.Actual Result]: 
4. Browser will open the first web site that you opened in step 3.  

[5.Reproduction build]: 
AriesKK v2.5(Affected)
Build ID               20151018193102
Gaia Revision          f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date              2015-10-16 13:00:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151018.185054
Firmware Date          Sun Oct 18 18:51:02 UTC 2015
Bootloader             s1

FlameKK v2.5(Affected)
Build ID               20151015150343
Gaia Revision          8ea9029190af2ffeb04dcd97b323738125e31a0e
Gaia Date              2015-10-15 14:30:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d374d16cbb251c9dac5af69f8e186e821ce82fe2
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151015.183044
Firmware Date          Thu Oct 15 18:30:54 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
16793
Attached video AriesKK_v2.5.3gp
Whiteboard: [systemsfe]
Ben, what do you think?
Flags: needinfo?(bfrancis)
QA Whiteboard: [COM=Pin the Web]
This looks like a bug in the scope matching and is related to the work Alberto is doing in bug 1216415.

I suspect what is happening here is that the start_url of the pinned site at /with_manifest/start_url.html is same origin with the window open at http://alison-shiue.github.io/without_manifest/icon_1.html and the latter window doesn't have a defined scope so its scope is the whole origin.

We should know that the scope of the pinned site is /with_manifest/ and therefore shouldn't reuse the window at /without_manifest/icon_1.html
Flags: needinfo?(bfrancis) → needinfo?(apastor)
[Blocking Requested - why for this release]:
Broken functionality
blocking-b2g: --- → 2.5?
Component: Gaia::Browser → Gaia::System::Window Mgmt
blocking-b2g: 2.5? → 2.5+
Assignee: nobody → apastor
Flags: needinfo?(apastor)
Comment on attachment 8678796 [details] [review]
[gaia] albertopq:1216083-pin-scope > mozilla-b2g:master

It seems we were not sending the bookmark scope when clicking on it. Guillaume, would you take a look?

Thanks!
Attachment #8678796 - Flags: review?(gmarty)
Comment on attachment 8678796 [details] [review]
[gaia] albertopq:1216083-pin-scope > mozilla-b2g:master

Perfect!
Attachment #8678796 - Flags: review?(gmarty) → review+
master: https://github.com/mozilla-b2g/gaia/commit/c1263f688ef88e9b15d96081b7305a3a1bae43f4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Hi Verson,

Verifyme please, thanks.
Flags: needinfo?(xiongfuchao)
Keywords: verifyme
Verified on

[Flame]
Build ID               20151027150240
Gaia Revision          a26eadc5e1133d5112b6cbc10badbb7670a1090f
Gaia Date              2015-10-27 17:36:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2b333a1d94e805a59c619ee41a6dec7fdcce505d
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151027.184038
Firmware Date          Tue Oct 27 18:40:49 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151027221526
Gaia Revision          a26eadc5e1133d5112b6cbc10badbb7670a1090f
Gaia Date              2015-10-27 17:36:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2b333a1d94e805a59c619ee41a6dec7fdcce505d
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151027.213419
Firmware Date          Tue Oct 27 21:34:27 UTC 2015
Bootloader             s1
Status: RESOLVED → VERIFIED
Flags: needinfo?(xiongfuchao)
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: