Closed Bug 1216087 Opened 5 years ago Closed 5 years ago

Pointer is not unlocked when ancestor of the pointer lock element is removed

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

Details

Attachments

(1 file)

If we have tree like:
> div#outer
> |
> +- div#inner
and request pointer lock on #inner. If we remove the #outer element from the document, the pointer is not unlocked. However, if we only remove #inner, the pointer is unlocked.
Bug 1216087 - Unlock pointer whenever the element is unbound from the tree.
Attachment #8675614 - Flags: review?(bugs)
Comment on attachment 8675614 [details]
MozReview Request: Bug 1216087 - Unlock pointer whenever the element is unbound from the tree.

bah, silly mistake
Attachment #8675614 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/272319a15188085adf710590289cf84b8192ca1a
Bug 1216087 - Unlock pointer whenever the element is unbound from the tree. r=smaug
Assignee: nobody → quanxunzhen
https://hg.mozilla.org/mozilla-central/rev/272319a15188
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8675614 [details]
MozReview Request: Bug 1216087 - Unlock pointer whenever the element is unbound from the tree.

Approval Request Comment
[Feature/regressing bug #]: pointer lock
[User impact if declined]: pointer may not be unlocked as expected in some case
[Describe test coverage new/current, TreeHerder]: test included
[Risks and why]: low risk, the change is simple and straightforward
[String/UUID change made/needed]: n/a
Attachment #8675614 - Flags: approval-mozilla-aurora?
Does this need to be in 43 for any particular reason?   Is it a regression (and if so, from when)
Can it ride with 44? I'd like for there to be more time for potential regressions to be uncovered if possible.
Flags: needinfo?(quanxunzhen)
This is not a regression. I believe this exists since we started supporting pointer lock. I consider this issue to be potentially harmful because we generate warnings for every mouse event when that happens.
Flags: needinfo?(quanxunzhen)
Comment on attachment 8675614 [details]
MozReview Request: Bug 1216087 - Unlock pointer whenever the element is unbound from the tree.

Approved for uplift to aurora, includes tests, ok on m-c.
Attachment #8675614 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.