Closed
Bug 1216087
Opened 9 years ago
Closed 9 years ago
Pointer is not unlocked when ancestor of the pointer lock element is removed
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla44
People
(Reporter: xidorn, Assigned: xidorn)
Details
Attachments
(1 file)
40 bytes,
text/x-review-board-request
|
smaug
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
If we have tree like:
> div#outer
> |
> +- div#inner
and request pointer lock on #inner. If we remove the #outer element from the document, the pointer is not unlocked. However, if we only remove #inner, the pointer is unlocked.
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1216087 - Unlock pointer whenever the element is unbound from the tree.
Attachment #8675614 -
Flags: review?(bugs)
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=868fc71ea3ba
Comment 3•9 years ago
|
||
Comment on attachment 8675614 [details] MozReview Request: Bug 1216087 - Unlock pointer whenever the element is unbound from the tree. bah, silly mistake
Attachment #8675614 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/272319a15188085adf710590289cf84b8192ca1a Bug 1216087 - Unlock pointer whenever the element is unbound from the tree. r=smaug
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → quanxunzhen
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/272319a15188
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8675614 [details] MozReview Request: Bug 1216087 - Unlock pointer whenever the element is unbound from the tree. Approval Request Comment [Feature/regressing bug #]: pointer lock [User impact if declined]: pointer may not be unlocked as expected in some case [Describe test coverage new/current, TreeHerder]: test included [Risks and why]: low risk, the change is simple and straightforward [String/UUID change made/needed]: n/a
Attachment #8675614 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
Does this need to be in 43 for any particular reason? Is it a regression (and if so, from when) Can it ride with 44? I'd like for there to be more time for potential regressions to be uncovered if possible.
Flags: needinfo?(quanxunzhen)
Assignee | ||
Comment 9•9 years ago
|
||
This is not a regression. I believe this exists since we started supporting pointer lock. I consider this issue to be potentially harmful because we generate warnings for every mouse event when that happens.
Flags: needinfo?(quanxunzhen)
Comment 10•9 years ago
|
||
Comment on attachment 8675614 [details] MozReview Request: Bug 1216087 - Unlock pointer whenever the element is unbound from the tree. Approved for uplift to aurora, includes tests, ok on m-c.
Attachment #8675614 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2a94d540599e
status-firefox43:
--- → fixed
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•