1216093 - Editing Pinned-Site causes icon to revert to default (rocket ship)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect, P2)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

STR:

1.) Go to m.facebook.com
2.) Pin site
3.) Goto homescreen, and drag facebook icon to config (check in the lower right)
4.) Change the name of the icon and hit "Done"

Expected result:
Icon remains facebook fav icon.

Actual result:
Icon becomes default rocket ship.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Thanks for picking this up Guillaume!

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1216093-Editing-Pinned-Site-causes-icon-revert-default > mozilla-b2g:master

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8675715 [details] [review]
[gaia] gmarty:Bug-1216093-Editing-Pinned-Site-causes-icon-revert-default > mozilla-b2g:master

Chris, how does this look?

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8675715 [details] [review]
[gaia] gmarty:Bug-1216093-Editing-Pinned-Site-causes-icon-revert-default > mozilla-b2g:master

Looks good!

Comment 5

[Chris Lord [:cwiiis]]

Tests green, merged: https://github.com/mozilla-b2g/gaia/commit/71540b8d8cc086c863bb6e91dc5b00799d6f4871

Comment 6

[Alison Shiue]

Verified on 

[Flame]
Build ID               20151020150236
Gaia Revision          11eb5d4cb2675d359d277ae17772bc75f7ccedbc
Gaia Date              2015-10-20 16:22:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f397034950304b845175f8dab8fccbdd0e8bf995
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151020.182846
Firmware Date          Tue Oct 20 18:28:58 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151021013240
Gaia Revision          11eb5d4cb2675d359d277ae17772bc75f7ccedbc
Gaia Date              2015-10-20 16:22:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/605de27d4e7f530159842649c02075c578d7a4a5
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151021.005126
Firmware Date          Wed Oct 21 00:51:34 UTC 2015
Bootloader             s1