1216094 - Failure in test_clock_set_alarm.py, AssertionError: 'Weekdays' != u'Mon, Tue, Wed, Thu, Fri'

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

I just saw this failure in the latest build:
TEST-UNEXPECTED-FAIL | test_clock_set_alarm.py TestClockSetAlarm.test_clock_set_alarm | AssertionError: 'Weekdays' != u'Mon, Tue, Wed, Thu, Fri'

Traceback (most recent call last):
  File "/Users/mwargers/.virtualenvs/zapion_test2/lib/python2.7/site-packages/marionette_client-1.0.0-py2.7.egg/marionette/marionette_test.py", line 296, in run
    testMethod()
  File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/tests/functional/clock/test_clock_set_alarm.py", line 30, in test_clock_set_alarm
    self.assertEqual('Weekdays', new_alarm.alarm_repeat)
TEST-INFO took 96157ms


I guess this might have changed recently.

Comment 1

[Johan Lorenzo [:jlorenzo]]

That looks like a bug in the product. I'll investigate that one.

Comment 2

[Johan Lorenzo [:jlorenzo]]

That's weird, I don't repro the problem on either [1] or [2]. Could this be an intermittent issue? Do you still repro today, Martijn?

[1] Build ID               20151018193102
Gaia Revision          f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date              2015-10-16 13:00:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151018.185054
Firmware Date          Sun Oct 18 18:51:02 UTC 2015
Bootloader             s1


[2] Build ID               20151019205841
Gaia Revision          a87f947366c2e044bd6336e1982419ac45378969
Gaia Date              2015-10-19 15:22:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151019.201730
Firmware Date          Mon Oct 19 20:17:38 UTC 2015
Bootloader             s1

Comment 3

[Martijn Wargers (dead)]

Yes, this failure happens all the time.
When I add in setup: self.data_layer.set_setting('time.timezone', 'Europe/Paris')
Then the test is passing. Also Europe/Amsterdam setting is passing.

This reminds me a lot of bug 1210466, comment 8 and further.

I guess my device somehow can't decide in which timezone I am or something and then it doesn't know if Mon-Fri is a weekdays combination?

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Here's the code that does the math: https://github.com/mozilla-b2g/gaia/blob/master/apps/clock/js/utils.js#L533-L536

I'm not sure if we changed anything that should affect your experience. Actually, one thing we did change is that it's async now. Not sure if it affects your tests, but maybe you'll be able to sprinkle some console.logs around that code?

Comment 5

[Martijn Wargers (dead)]

That shouldn't affect this test, the async thing. Somehow, it seems timezone related, apparently.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

I would be surprised if it was timezone related. The bug seems to be that it doesn't switch "Mon, Tue, Wed, Thu, Fri" into "Weekdays", which is irrelevant of timezone.

Comment 7

[Martijn Wargers (dead)]

But why does changing the time.timezone to Europe/Paris or Europe/Amsterdam make it work then? That seems to me an indication that it is timezone related.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

true. I have no idea how can it be co-related. There's nothing about this code that does datetime computations. Pure list of options and if 5 are selected, picks "Weekdays" instead.

Comment 9

[Martijn Wargers (dead)]

Marking WONTFIX, sorry for the bug spam. If somebody still wants to work on this, please file a new bug for it.