Closed
Bug 1216171
Opened 9 years ago
Closed 9 years ago
MozbuildObject.bindir imports the wrong mozinfo
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox44 fixed)
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file)
This is fallout from bug 1060562. See https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/base.py#281 It's attempting to use the mozinfo module to get the current platform. But it's instead importing python/mozbuild/mozbuild/mozinfo.py, which while it's confusingly named the same, is not the same at all. But even if it did import the right module, it would still be broken, as it should be using "mozinfo.info['os']" instead of "mozinfo.os".
|
Assignee | |
Comment 1•9 years ago
|
||
Bug 1216171 - Fix MozbuildObject.bindir to import the correct mozinfo, r=jmaher
Attachment #8675724 -
Flags: review?(jmaher)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8675724 [details] MozReview Request: Bug 1216171 - Fix MozbuildObject.bindir to import the correct mozinfo, r=jmaher https://reviewboard.mozilla.org/r/22419/#review20003 lgtm
Attachment #8675724 -
Flags: review?(jmaher) → review+
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7448a7275cd7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•