1216176 - [Messages] We can see the "carrier subheader" in the edit mode

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Julien Wajsberg [:julienw]]

STR:
0. Enter the Messages app.
1. Enter a conversation with one known contact.
=> notice there is a subheader with the carrier and phone number information.
2. Press the top right button, then "select messages".

=> notice the subheader is still displayed.
It should be hidden.

This is a regression from previous versions (but I don't know it was working as expected in 2.2).

QA, please do a branch checks on previous versions.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Hi Julien, can you provide a screenshot showing the current situation?

Comment 2

[Oleg Zasypkin [:azasypkin]]

Sounds like a right moment to add integration test for this :) Will make sure we'll cover it in the scope bug 1209419.

Comment 3

[Tony(Leave from Mozilla)]

This bug can be repro on the old/latest build of Flame KK 2.2&2.5 and Aries KK 2.5 by the STR in comment 0. It is not a regression bug. 

Actual results: The "carrier subheader" is shown in the edit mode.
See attachments: verified_logcat_1743.txt, verified_Aries_KK v2.5.3gp.
Reproduce rate: 10/10.

Device: Flame KK 2.5 latest build (affected)
Build ID               20151019150205
Gaia Revision          a87f947366c2e044bd6336e1982419ac45378969
Gaia Date              2015-10-19 15:22:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151019.182947
Firmware Date          Mon Oct 19 18:29:58 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 latest build (affected)
Build ID               20151019205841
Gaia Revision          a87f947366c2e044bd6336e1982419ac45378969
Gaia Date              2015-10-19 15:22:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151019.201730
Firmware Date          Mon Oct 19 20:17:38 UTC 2015
Bootloader             s1

Device: Flame KK 2.5 old build (affected)
Build ID               20150113010202
Gaia Revision          9946a490a9264b42e65385d703b28fa055ab2d42
Gaia Date              2015-01-12 20:31:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3d846527576f
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150113.043738
Firmware Date          Tue Jan 13 04:37:49 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.2 old build (affected)
Build ID               20150601002502
Gaia Revision          b4582cc394e0919623263997c0cdb0b4751a1403
Gaia Date              2015-05-31 11:06:34
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/78d8b0a4303d
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150601.040105
Firmware Date          Mon Jun  1 04:01:17 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 4

[Tony(Leave from Mozilla)]

Attachment: verified_logcat_1743.txt

Comment 5

[Tony(Leave from Mozilla)]

Attachment: verified_Aries_KK v2.5.3gp

Comment 6

[Julien Wajsberg [:julienw]]

QA, can you please look for this in previous branches than 2.2 as well?

Thanks.

Comment 7

[Julien Wajsberg [:julienw]]

Attachment: 2015-10-20-09-59-50.png

See the attachment, we should not have the subheader below the title in edit mode.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comms triage: Not a regression from 2.2. The bug might not be detected by an end user. This is a nice to have, but we won't hold the release on it.

Comment 9

[Tony(Leave from Mozilla)]

Attachment: verified_Flame_2.0&2.1.png

(In reply to Julien Wajsberg [:julienw] from comment #6)
> QA, can you please look for this in previous branches than 2.2 as well?
> 
> Thanks.

Hi Julien, 
We Creat a contact with Name, carrier and phone  number.
1. "Mobile, Carrier" is displayed as subheader on v2.0.
2. "Mobile, Phone Number,Carrier " is displayed as subheader on v2.1
Rate:10/10
Device: Flame KK_v2.0
Build ID               20150715160205
Gaia Revision          b16ba05481e577bc644ed8966f587a70fe2148e6
Gaia Date              2015-07-07 22:41:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/45795565d229
Gecko Version          32.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150715.193516
Firmware Date          Wed Jul 15 19:35:28 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK_v2.1
Build ID               20141008161201
Gaia Revision          7ef2e1e59637a34ca4489c329b3bdee93df3ac6c
Gaia Date              2014-10-08 12:32:21
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/e3d495eb85c6
Gecko Version          34.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20141008.195811
Firmware Date          Wed Oct  8 19:58:25 EDT 2014
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 10

[Julien Wajsberg [:julienw]]

OK, I'm surprised, I'll ask Steve then, maybe I'm just confused.

Hey Steve, what do you remember about this subheader appearing in edit mode?

Comment 11

[Steve Chung [:steveck]]

I'm afraid that we never handle it properly... If we simply hide the subheader, there would be a space on top of the messages. If we hide the message and adjust the margins, you can see the message bubbles jump up. But I didn't remember we did such things for removing the subheader, and I think UX might not be willing to do so either.

Comment 12

[Julien Wajsberg [:julienw]]

NI for me, I'll try to find out how it works in previous versions.

Comment 13

[Julien Wajsberg [:julienw]]

I checked 1.3 and we have the same behavior. So likely I was just confused, sorry for the noise.