1216195 - use mozilla/Endian.h facilities in bluetooth code

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Nathan Froyd [:froydnj]]

We have a number of functions in mozilla/Endian.h for doing endianness
conversions, and these functions should be used instead of hand-rolled
functions.  Using those functions in the bluetooth code makes the code
clearer and more portable (ReadLittleEndianUint16 won't do the right
thing if we're running on a big-endian processor, for instance).
Endian.h is also careful to avoid assumptions about memory alignment,
which utility functions like ReadLittleEndianUint16 don't do.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use mozilla/Endian.h facilities in bluetooth code

Comment 2

[Ben Tian (inactive)]

Comment on attachment 8675764 [details] [diff] [review]
use mozilla/Endian.h facilities in bluetooth code

Review of attachment 8675764 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed. Thanks for fixing this!

::: dom/bluetooth/bluedroid/BluetoothMapSmsManager.cpp
@@ +724,5 @@
>  
>    // Folder listing size
>    int foldersize = mCurrentFolder->GetSubFolderCount();
>  
>    // Convert little endian to big endian

remove this redundant comment.

::: dom/bluetooth/bluedroid/BluetoothPbapManager.cpp
@@ +11,5 @@
>  #include "BluetoothSocket.h"
>  #include "BluetoothUtils.h"
>  #include "BluetoothUuid.h"
>  
> +#include "mozilla/Endian.h"

nit: alphabetical order. move this include to right before "File.h".

::: dom/bluetooth/bluedroid/BluetoothSocketMessageWatcher.cpp
@@ +9,5 @@
>  #include <unistd.h>
>  #include <sys/socket.h>
>  #include "BluetoothInterface.h"
>  #include "nsClassHashtable.h"
> +#include "mozilla/Endian.h"

nit: alphabetical order. move this include to right before "nsClassHashtable.h".

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/38f2959a97b2

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/38f2959a97b2