1216207 - Expose support for late-customization using `navigator.hasFeature()`

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[David Durst [:ddurst]]

In looking at the late customization feature, we realized that on the consumer side the only way to limit it to 2.5+ was to use hasFeature("web-extensions") -- the methodology we're using to identify 2.5 via add-ons support -- but we determined that that's lousy. We don't want to infer a version from the support of something else.

Instead, we could just say if "late-customization" is supported. CCing sfoster, in case this would also change things on his side. Marking as P1 because of time-sensitivity.

Comment 1

[Sam Foster [:sfoster] (he/him)]

What would constitute support? Perhaps the presence of a truthy value for the latecustomization.url mozSetting?

Comment 2

[Mathieu Pillard [:mat]]

I think that would be enough, yes. Most hasFeature() flags are hardcoded (the important point being that older devices don't have the hardcoded value and therefore don't return true)

Comment 3

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: A very simple approach, hardcoded check.

... this is like the previous web-extensions feature check but with the proper name, should be enough.

Comment 4

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: Expose late-customization feature

Comment 5

[(no longer active)]

Comment on attachment 8677591 [details] [diff] [review]
Expose late-customization feature

This needs a test in test_hasFeature.html.

Also, please submit patches with 8 lines of context in the future.  Thanks!

Comment 6

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: Add late-customization feature detection and unit test

Slightly modified the test to make easy add new future features.

Comment 7

[[:fabrice] Fabrice Desré]

Comment on attachment 8678816 [details] [diff] [review]
Add late-customization feature detection and unit test

Review of attachment 8678816 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/test/test_hasFeature.html
@@ +64,5 @@
>    if (!b2gOnly) {
>      return Promise.resolve();
>    }
>  
> +  var builtInFeatures = [ 

nit: trailing whitespace.

@@ +66,5 @@
>    }
>  
> +  var builtInFeatures = [ 
> +    {feature: "web-extensions", value: true},
> +    {feature: "late-customization", value: true} 

here too

Comment 8

[(no longer active)]

Comment on attachment 8678816 [details] [diff] [review]
Add late-customization feature detection and unit test

Review of attachment 8678816 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the trailing whitespaces fixed.

Comment 9

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: Add late-customization feature detection and unit test (v2)

Comment 10

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8679182 [details] [diff] [review]
Add late-customization feature detection and unit test (v2)

Whitespace corrected, carrying ehsan's r+

Comment 11

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/080fb640f419

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/080fb640f419