Closed Bug 1216217 Opened 6 years ago Closed 6 years ago

Selecting an item from the 'workers' list in the debugger no longer works

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

This regressed as part of Bug 1178726, it looks like an additional parameter was added to _onWorkerSelect causing undefined to be passed in as the workerActor to DebuggerController.client.attachWorker: https://hg.mozilla.org/mozilla-central/rev/c07248ffb454#l1.90
Blocks: 1215117
Bug 1216217 - Make selecting a worker from the debugger's worker list work;r=jlongster
Attachment #8675790 - Flags: review?(jlong)
Trivial fix.. assuming try will be green since there doesn't seem to be test coverage for this (although I'm working to fix that in Bug 1215117).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8ec9fdd64fc
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8675790 - Flags: review?(jlong) → review+
Comment on attachment 8675790 [details]
MozReview Request: Bug 1216217 - Make selecting a worker from the debugger's worker list work;r=jlongster

https://reviewboard.mozilla.org/r/22427/#review20047

This broke on Oct 16 in git commit f7c6589364e999902ba5591a46dc7a3ffcb5c459. I guess we don't have tests yet.

::: devtools/client/debugger/debugger-controller.js:483
(Diff revision 1)
> -  _onWorkerSelect: function (type, workerActor) {
> +  _onWorkerSelect: function (workerActor) {

Are you sure you're supposed to remove `type`? If it's using EventEmitter that will be the event name.

(I'm sure you tested this though)
(In reply to James Long (:jlongster) from comment #3)
> ::: devtools/client/debugger/debugger-controller.js:483
> (Diff revision 1)
> > -  _onWorkerSelect: function (type, workerActor) {
> > +  _onWorkerSelect: function (workerActor) {
> 
> Are you sure you're supposed to remove `type`? If it's using EventEmitter
> that will be the event name.
> 
> (I'm sure you tested this though)

This is being called directly from another function, not by the EventEmitter: https://dxr.mozilla.org/mozilla-central/source/devtools/client/debugger/views/workers-view.js#40
https://hg.mozilla.org/mozilla-central/rev/f3eba94017f7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.