Add function to provide accurate Firefox channel/version info based on mozUITour API

RESOLVED FIXED

Status

--
enhancement
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kohei, Assigned: kohei)

Tracking

(Blocks: 1 bug)

Production
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1876707])

Attachments

(1 attachment)

My pull request for Bug 939470 is now ready, but before solving the bug on the critical /firefox/new/ page, we need some tests on other pages using GA events so we can analyze how many people are hitting the fallback code and how many people are using a minor Firefox release, etc.
Hi Gareth, I'm adding a new GA event here. It happens when the user's Firefox version number and channel info is retrieved via the mozUITour API, and includes the version, channel, whether the version is up-to-date or not, and whether the info is accurate or not (in case the API didn't work for some reason). The event will be removed maybe in a month once we gain an insight into the accuracy of the API and the freshness of Firefox. Does it work for you?

https://github.com/kyoshino/bedrock/commit/995d7b008acf5057c7ccce287a15760df6fba952#diff-8e44ab1d2ba495153c12b57837b6d8eeR134
Flags: needinfo?(garethcull.bugs)
This is now up on demo2:

Pages that will need testing:

https://www-demo2.allizom.org/en-US/plugincheck/
https://www-demo2.allizom.org/en-US/firefox/desktop/
https://www-demo2.allizom.org/en-US/firefox/desktop/tips/
https://www-demo2.allizom.org/en-US/firefox/products/

Note: we're not adding this to /firefox/new/ until after we're confident the data looks OK.
Thanks guys.

Alex, 

Can I snag 10 minutes of your time Alex early next Tuesday or Wed to review? I'll ping you in IRC and we can hop on vidyo if that works. Thanks.

Gareth
Flags: needinfo?(garethcull.bugs)
(In reply to Gareth Cull [:garethc] from comment #4)
> Thanks guys.
> 
> Alex, 
> 
> Can I snag 10 minutes of your time Alex early next Tuesday or Wed to review?
> I'll ping you in IRC and we can hop on vidyo if that works. Thanks.
> 
> Gareth

Sure, happy to talk you through what we're doing and what we'd like to get some data on. Thanks, Gareth!
Testing notes for Firefox 42 (release)
--------------------------------------
browser.uitour.testingOrigins = https://www-demo2.allizom.org/
browser.uitour.enabled = true
Mozilla.Client.FirefoxDetails = { version: "42.0", channel: "release", isUpToDate: true, isESR: false }

https://www-demo2.allizom.org/en-US/plugincheck/ - no download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/ - no download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/tips/ - no download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/products/ - no download button visible (PASS)

browser.uitour.testingOrigins = https://www-demo2.allizom.org/
browser.uitour.enabled = false
Mozilla.Client.FirefoxDetails = { version: "42.0", channel: "release", isUpToDate: true, isESR: false }

https://www-demo2.allizom.org/en-US/plugincheck/ - no download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/ - no download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/tips/ - no download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/products/ - no download button visible (PASS)

The only small issue I noticed was on the the /firefox/products/ page, where there is now a visible flash of the download prompt before it disappears again. This is visible with uitour both enabled and disabled.
Testing notes for Firefox 38.4.0 (ESR)
--------------------------------------
browser.uitour.testingOrigins = https://www-demo2.allizom.org/
browser.uitour.enabled = true
Mozilla.Client.FirefoxDetails = { accurate: true, version: "38.4.0", channel: "esr", isUpToDate: true, isESR: true }

https://www-demo2.allizom.org/en-US/plugincheck/ - no download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/ - no download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/tips/ - no download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/products/ - no download button visible (PASS)

browser.uitour.testingOrigins = https://www-demo2.allizom.org/
browser.uitour.enabled = false
Mozilla.Client.FirefoxDetails = { accurate: false, version: "38.0", channel: "release", isUpToDate: false, isESR: false }

https://www-demo2.allizom.org/en-US/plugincheck/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/tips/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/products/ - download button visible (PASS)
Testing notes for Firefox 38.0.6 (Release)
------------------------------------------
browser.uitour.testingOrigins = https://www-demo2.allizom.org/
browser.uitour.enabled = true
Mozilla.Client.FirefoxDetails = { accurate: true, version: "38.0.6", channel: "release", isUpToDate: false, isESR: false }

https://www-demo2.allizom.org/en-US/plugincheck/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/tips/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/products/ - download button visible (PASS)

browser.uitour.testingOrigins = https://www-demo2.allizom.org/
browser.uitour.enabled = false
Mozilla.Client.FirefoxDetails = { accurate: false, version: "38.0", channel: "release", isUpToDate: false, isESR: false }

https://www-demo2.allizom.org/en-US/plugincheck/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/tips/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/products/ - download button visible (PASS)
Testing notes for Firefox 35.0 (Release)
----------------------------------------
browser.uitour.testingOrigins = https://www-demo2.allizom.org/
browser.uitour.enabled = true
Mozilla.Client.FirefoxDetails = { accurate: true, version: "35.0", channel: "release", isUpToDate: false, isESR: false }

https://www-demo2.allizom.org/en-US/plugincheck/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/tips/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/products/ - download button visible (PASS)

browser.uitour.testingOrigins = https://www-demo2.allizom.org/
browser.uitour.enabled = false
Mozilla.Client.FirefoxDetails = { accurate: false, version: "35.0", channel: "release", isUpToDate: false, isESR: false }

https://www-demo2.allizom.org/en-US/plugincheck/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/tips/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/products/ - download button visible (PASS)
Testing notes for Firefox 34.0 (Release)
----------------------------------------
browser.uitour.testingOrigins = https://www-demo2.allizom.org/
browser.uitour.enabled = true
Mozilla.Client.FirefoxDetails = { accurate: false, version: "34.0", channel: "release", isUpToDate: false, isESR: false }

https://www-demo2.allizom.org/en-US/plugincheck/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/tips/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/products/ - download button visible (PASS)

browser.uitour.testingOrigins = https://www-demo2.allizom.org/
browser.uitour.enabled = false
Mozilla.Client.FirefoxDetails = { accurate: false, version: "34.0", channel: "release", isUpToDate: false, isESR: false }

https://www-demo2.allizom.org/en-US/plugincheck/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/desktop/tips/ - download button visible (PASS)
https://www-demo2.allizom.org/en-US/firefox/products/ - download button visible (PASS)
So far, testing looks good thanks Kohei!
Gareth, would you be free to catch up either Friday or Monday to chat about GA for this change? I think we'll be ready to merge this one soon.
Flags: needinfo?(garethcull.bugs)
Sounds good. I've sent you an invite for tomorrow morning.
Flags: needinfo?(garethcull.bugs)
GA event to track:

window.dataLayer.push({
  'event': 'firefox-details-retrieved',
  'accurate': accurate,
  'version': version,
  'channel': channel,
  'isUpToDate': isUpToDate,
  'isESR': isESR
});

Comment 15

3 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/b262ae3b0ebe5e934887577369703e48fb5764d5
Fix Bug 1216225 - Add function to provide accurate Firefox channel/version info based on mozUITour API

https://github.com/mozilla/bedrock/commit/1584f9e386f6fd81f7c0634f31e2569c2c37a9ea
Merge pull request #3451 from kyoshino/bug-1216225-get-firefox-details

Bug 1216225 - Add function to provide accurate Firefox channel/version info based on mozUITour API

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Gareth, now that this has been on prod for a little while, can you please take a look at the event data we discussed above for the 4 URLs?
Flags: needinfo?(garethcull.bugs)
Looks like this has dropped off the radar, Gareth can we please get an update on this one sometime soon? Thanks
Sorry for the delay on this Alex. I've added it to my next sprint and will get this to you next week.
Flags: needinfo?(garethcull.bugs)
You need to log in before you can comment on or make changes to this bug.